Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/browser/chromeos/login/message_bubble.cc

Issue 8221027: Make views::Label and views::Link auto-color themselves to be readable over their background colo... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/message_bubble.h" 5 #include "chrome/browser/chromeos/login/message_bubble.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 ResourceBundle& rb = ResourceBundle::GetSharedInstance(); 59 ResourceBundle& rb = ResourceBundle::GetSharedInstance();
60 60
61 layout->StartRow(0, 0); 61 layout->StartRow(0, 0);
62 icon_ = new views::ImageView(); 62 icon_ = new views::ImageView();
63 icon_->SetImage(*image); 63 icon_->SetImage(*image);
64 layout->AddView(icon_); 64 layout->AddView(icon_);
65 65
66 text_ = new views::Label(WideToUTF16Hack(text)); 66 text_ = new views::Label(WideToUTF16Hack(text));
67 text_->SetMultiLine(true); 67 text_->SetMultiLine(true);
68 text_->SetHorizontalAlignment(views::Label::ALIGN_LEFT); 68 text_->SetHorizontalAlignment(views::Label::ALIGN_LEFT);
69 text_->SetBackgroundColor(Bubble::kBackgroundColor);
69 text_->SizeToFit(kMaxLabelWidth); 70 text_->SizeToFit(kMaxLabelWidth);
70 layout->AddView(text_); 71 layout->AddView(text_);
71 72
72 close_button_ = new views::ImageButton(this); 73 close_button_ = new views::ImageButton(this);
73 close_button_->SetImage(views::CustomButton::BS_NORMAL, 74 close_button_->SetImage(views::CustomButton::BS_NORMAL,
74 rb.GetBitmapNamed(IDR_CLOSE_BAR)); 75 rb.GetBitmapNamed(IDR_CLOSE_BAR));
75 close_button_->SetImage(views::CustomButton::BS_HOT, 76 close_button_->SetImage(views::CustomButton::BS_HOT,
76 rb.GetBitmapNamed(IDR_CLOSE_BAR_H)); 77 rb.GetBitmapNamed(IDR_CLOSE_BAR_H));
77 close_button_->SetImage(views::CustomButton::BS_PUSHED, 78 close_button_->SetImage(views::CustomButton::BS_PUSHED,
78 rb.GetBitmapNamed(IDR_CLOSE_BAR_P)); 79 rb.GetBitmapNamed(IDR_CLOSE_BAR_P));
79 layout->AddView(close_button_); 80 layout->AddView(close_button_);
80 81
81 for (size_t i = 0; i < links.size(); ++i) { 82 for (size_t i = 0; i < links.size(); ++i) {
82 layout->StartRowWithPadding(0, 1, 0, kBorderSize); 83 layout->StartRowWithPadding(0, 1, 0, kBorderSize);
83 views::Link* help_link_ = new views::Link(WideToUTF16Hack(links[i])); 84 views::Link* help_link_ = new views::Link(WideToUTF16Hack(links[i]));
84 help_links_.push_back(help_link_); 85 help_links_.push_back(help_link_);
85 help_link_->set_listener(this); 86 help_link_->set_listener(this);
86 help_link_->SetNormalColor(login::kLinkColor); 87 help_link_->SetBackgroundColor(Bubble::kBackgroundColor);
87 help_link_->SetHighlightedColor(login::kLinkColor); 88 help_link_->SetEnabledColor(login::kLinkColor);
89 help_link_->SetPressedColor(login::kLinkColor);
88 layout->AddView(help_link_); 90 layout->AddView(help_link_);
89 } 91 }
90 } 92 }
91 93
92 MessageBubble::~MessageBubble() { 94 MessageBubble::~MessageBubble() {
93 } 95 }
94 96
95 void MessageBubble::ButtonPressed(views::Button* sender, 97 void MessageBubble::ButtonPressed(views::Button* sender,
96 const views::Event& event) { 98 const views::Event& event) {
97 if (sender == close_button_) { 99 if (sender == close_button_) {
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 #if !defined(TOUCH_UI) && defined(TOOLKIT_USES_GTK) 199 #if !defined(TOUCH_UI) && defined(TOOLKIT_USES_GTK)
198 gboolean MessageBubble::OnButtonPress(GtkWidget* widget, 200 gboolean MessageBubble::OnButtonPress(GtkWidget* widget,
199 GdkEventButton* event) { 201 GdkEventButton* event) {
200 NativeWidgetGtk::OnButtonPress(widget, event); 202 NativeWidgetGtk::OnButtonPress(widget, event);
201 // Never propagate event to parent. 203 // Never propagate event to parent.
202 return true; 204 return true;
203 } 205 }
204 #endif 206 #endif
205 207
206 } // namespace chromeos 208 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/login/background_view.cc ('k') | chrome/browser/chromeos/login/network_selection_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698