Make views::Label and views::Link auto-color themselves to be readable over their background colo...

chrome/browser/chromeos/input_method/candidate_window.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/input_method/candidate_window.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 101 matching lines @@
       views::GridLayout::FILL, views::GridLayout::FILL,
       1, views::GridLayout::USE_PREF, 0, 0);
   layout->StartRow(0, 0);
 
   // Add the view contents.
   layout->AddView(view);  // |view| is owned by |wraper|, not |layout|.
   return wrapper;
 }
 
 // Creates shortcut text from the given index and the orientation.
-std::wstring CreateShortcutText(
-    int index,
-    InputMethodLookupTable::Orientation orientation) {
+string16 CreateShortcutText(int index,
+                            InputMethodLookupTable::Orientation orientation) {
   // Choose the character used for the shortcut label.
-  const wchar_t kShortcutCharacters[] = L"1234567890ABCDEF";
+  const char kShortcutCharacters[] = "1234567890ABCDEF";
   // The default character should not be used but just in case.
-  wchar_t shortcut_character = L'?';
+  char shortcut_character = L'?';
   // -1 to exclude the null character at the end.
-  if (index < static_cast<int>(arraysize(kShortcutCharacters) - 1)) {
+  if (index < static_cast<int>(arraysize(kShortcutCharacters) - 1))
     shortcut_character = kShortcutCharacters[index];
-  }
 
-  std::wstring shortcut_text;
-  if (orientation == InputMethodLookupTable::kVertical) {
-    shortcut_text = base::StringPrintf(L"%lc", shortcut_character);
-  } else {
-    shortcut_text = base::StringPrintf(L"%lc.", shortcut_character);
-  }
-
-  return shortcut_text;
+  std::string shortcut_text(1, shortcut_character);
+  if (orientation != InputMethodLookupTable::kVertical)
+    shortcut_text += '.';
+  return ASCIIToUTF16(shortcut_text);
 }
 
 // Creates the shortcut label, and returns it (never returns NULL).
 // The label text is not set in this function.
 views::Label* CreateShortcutLabel(
     InputMethodLookupTable::Orientation orientation) {
   // Create the shortcut label. The label will be owned by
   // |wrapped_shortcut_label|, hence it's deleted when
   // |wrapped_shortcut_label| is deleted.
   views::Label* shortcut_label = new views::Label;
 
   if (orientation == InputMethodLookupTable::kVertical) {
     shortcut_label->SetFont(
         shortcut_label->font().DeriveFont(kFontSizeDelta, gfx::Font::BOLD));
   } else {
     shortcut_label->SetFont(
         shortcut_label->font().DeriveFont(kFontSizeDelta));
   }
   // TODO(satorux): Maybe we need to use language specific fonts for
   // candidate_label, like Chinese font for Chinese input method?
-  shortcut_label->SetColor(kShortcutColor);
+  shortcut_label->SetEnabledColor(kShortcutColor);
+  shortcut_label->SetDisabledColor(kDisabledShortcutColor);
 
   return shortcut_label;
 }
 
 // Wraps the shortcut label, then decorates wrapped shortcut label
 // and returns it (never returns NULL).
 // The label text is not set in this function.
 views::View* CreateWrappedShortcutLabel(
     views::Label* shortcut_label,
     InputMethodLookupTable::Orientation orientation) {
   // Wrap it with padding.
   const gfx::Insets kVerticalShortcutLabelInsets(1, 6, 1, 6);
   const gfx::Insets kHorizontalShortcutLabelInsets(1, 3, 1, 0);
   const gfx::Insets insets =
       (orientation == InputMethodLookupTable::kVertical ?
        kVerticalShortcutLabelInsets :
        kHorizontalShortcutLabelInsets);
   views::View* wrapped_shortcut_label =
       WrapWithPadding(shortcut_label, insets);
 
   // Add decoration based on the orientation.
   if (orientation == InputMethodLookupTable::kVertical) {
     // Set the background color.
     wrapped_shortcut_label->set_background(
         views::Background::CreateSolidBackground(
             kShortcutBackgroundColor));
+    shortcut_label->SetBackgroundColor(
+        wrapped_shortcut_label->background()->get_color());
   }
 
   return wrapped_shortcut_label;
 }
 
 // Creates the candidate label, and returns it (never returns NULL).
 // The label text is not set in this function.
 views::Label* CreateCandidateLabel(
     InputMethodLookupTable::Orientation orientation) {
   views::Label* candidate_label = NULL;
@@ skipping 17 matching lines @@
 // Creates the annotation label, and return it (never returns NULL).
 // The label text is not set in this function.
 views::Label* CreateAnnotationLabel(
     InputMethodLookupTable::Orientation orientation) {
   // Create the annotation label.
   views::Label* annotation_label = new views::Label;
 
   // Change the font size and color.
   annotation_label->SetFont(
       annotation_label->font().DeriveFont(kFontSizeDelta));
-  annotation_label->SetColor(kAnnotationColor);
+  annotation_label->SetEnabledColor(kAnnotationColor);
   annotation_label->SetHorizontalAlignment(views::Label::ALIGN_LEFT);
 
   return annotation_label;
 }
 
 // Computes shortcut column width.
 int ComputeShortcutColumnWidth(
     const InputMethodLookupTable& lookup_table) {
   int shortcut_column_width = 0;
   // Create the shortcut label. The label will be owned by
   // |wrapped_shortcut_label|, hence it's deleted when
   // |wrapped_shortcut_label| is deleted.
   views::Label* shortcut_label = CreateShortcutLabel(lookup_table.orientation);
   scoped_ptr<views::View> wrapped_shortcut_label(
       CreateWrappedShortcutLabel(shortcut_label, lookup_table.orientation));
 
   // Compute the max width in shortcut labels.
   // We'll create temporary shortcut labels, and choose the largest width.
   for (int i = 0; i < lookup_table.page_size; ++i) {
-    shortcut_label->SetText(
-        WideToUTF16Hack(CreateShortcutText(i, lookup_table.orientation)));
+    shortcut_label->SetText(CreateShortcutText(i, lookup_table.orientation));
     shortcut_column_width =
         std::max(shortcut_column_width,
                  wrapped_shortcut_label->GetPreferredSize().width());
   }
 
   return shortcut_column_width;
 }
 
 // Computes the page index. For instance, if the page size is 9, and the
 // cursor is pointing to 13th candidate, the page index will be 1 (2nd
@@ skipping 127 matching lines @@
 
     const gfx::Insets kInsets(2, 2, 2, 4);
     views::View* contents = WrapWithPadding(label_, kInsets);
     SetContents(contents);
     contents->set_border(
         views::Border::CreateSolidBorder(1, kFrameColor));
     contents->set_background(
         views::Background::CreateVerticalGradientBackground(
             kFooterTopColor,
             kFooterBottomColor));
+    label_->SetBackgroundColor(contents->background()->get_color());
   }
 
   // Set the displayed text.
   void SetText(const std::string& utf8_text) {
     label_->SetText(UTF8ToUTF16(utf8_text));
   }
 
  protected:
   virtual gfx::Size GetPreferredSize() OVERRIDE {
     gfx::Size size = HidableArea::GetPreferredSize();
@@ skipping 184 matching lines @@
                 int index_in_page,
                 InputMethodLookupTable::Orientation orientation);
   virtual ~CandidateView() {}
   // Initializes the candidate view with the given column widths.
   // A width of 0 means that the column is resizable.
   void Init(int shortcut_column_width,
             int candidate_column_width,
             int annotation_column_width);
 
   // Sets candidate text to the given text.
-  void SetCandidateText(const std::wstring& text);
+  void SetCandidateText(const string16& text);
 
   // Sets shortcut text to the given text.
-  void SetShortcutText(const std::wstring& text);
+  void SetShortcutText(const string16& text);
 
   // Sets annotation text to the given text.
-  void SetAnnotationText(const std::wstring& text);
+  void SetAnnotationText(const string16& text);
 
   // Sets infolist icon.
   void SetInfolistIcon(bool enable);
 
   // Selects the candidate row. Changes the appearance to make it look
   // like a selected candidate.
   void Select();
 
   // Unselects the candidate row. Changes the appearance to make it look
   // like an unselected candidate.
   void Unselect();
 
   // Enables or disables the candidate row based on |enabled|. Changes the
   // appearance to make it look like unclickable area.
   void SetRowEnabled(bool enabled);
 
   // Returns the relative position of the candidate label.
   gfx::Point GetCandidateLabelPosition() const;
 
  private:
   // Overridden from View:
   virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE;
 
+  // Notifies labels of their new background colors.  Called whenever the view's
+  // background color changes.
+  void UpdateLabelBackgroundColors();
+
   // Zero-origin index in the current page.
   int index_in_page_;
 
   // The orientation of the candidate view.
   InputMethodLookupTable::Orientation orientation_;
 
   // The parent candidate window that contains this view.
   CandidateWindowView* parent_candidate_window_;
 
   // Views created in the class will be part of tree of |this|, so these
   // child views will be deleted when |this| is deleted.
 
   // The shortcut label renders shortcut numbers like 1, 2, and 3.
   views::Label* shortcut_label_;
   // The candidate label renders candidates.
   views::Label* candidate_label_;
   // The annotation label renders annotations.
   views::Label* annotation_label_;
 
   // The infolist icon.
   views::Label* infolist_label_;
   bool infolist_icon_enabled_;
 };
 
 class InfolistView;
 
 // InfolistWindowView is the main container of the infolist window UI.
 class InfolistWindowView : public views::View {
  public:
-  InfolistWindowView(
-      views::Widget* parent_frame, views::Widget* candidate_window_frame);
+  InfolistWindowView(views::Widget* parent_frame,
+                     views::Widget* candidate_window_frame);
   virtual ~InfolistWindowView();
   void Init();
   void Show();
   void DelayShow(unsigned int milliseconds);
   void Hide();
   void DelayHide(unsigned int milliseconds);
   void UpdateCandidates(const InputMethodLookupTable& lookup_table);
 
   void ResizeAndMoveParentFrame();
 
@@ skipping 45 matching lines @@
 
   // Selects the infolist row. Changes the appearance to make it look
   // like a selected candidate.
   void Select();
 
   // Unselects the infolist row. Changes the appearance to make it look
   // like an unselected candidate.
   void Unselect();
 
  private:
+  // Notifies labels of their new background colors.  Called whenever the view's
+  // background color changes.
+  void UpdateLabelBackgroundColors();
+
   // The parent candidate window that contains this view.
   InfolistWindowView* parent_infolist_window_;
 
   // Views created in the class will be part of tree of |this|, so these
   // child views will be deleted when |this| is deleted.
 
   // The title label.
   views::Label* title_label_;
   // The description label.
   views::Label* description_label_;
@@ skipping 119 matching lines @@
   layout->StartRow(0, 0);
   // |wrapped_shortcut_label|, |candidate_label_|, and |annotation_label_|
   // will be owned by |this|.
   layout->AddView(wrapped_shortcut_label);
   layout->AddView(candidate_label_);
   layout->AddView(annotation_label_);
   if (orientation_ == InputMethodLookupTable::kVertical) {
     layout->AddView(WrapWithPadding(infolist_label_,
         gfx::Insets(2, 0, 2, 0)));
   }
+  UpdateLabelBackgroundColors();
 }
 
-void CandidateView::SetCandidateText(const std::wstring& text) {
-  candidate_label_->SetText(WideToUTF16Hack(text));
+void CandidateView::SetCandidateText(const string16& text) {
+  candidate_label_->SetText(text);
 }
 
-void CandidateView::SetShortcutText(const std::wstring& text) {
-  shortcut_label_->SetText(WideToUTF16Hack(text));
+void CandidateView::SetShortcutText(const string16& text) {
+  shortcut_label_->SetText(text);
 }
 
-void CandidateView::SetAnnotationText(const std::wstring& text) {
-  annotation_label_->SetText(WideToUTF16Hack(text));
+void CandidateView::SetAnnotationText(const string16& text) {
+  annotation_label_->SetText(text);
 }
 
 void CandidateView::SetInfolistIcon(bool enable) {
-  if (!infolist_label_) {
+  if (!infolist_label_ || (infolist_icon_enabled_ == enable))
     return;
-  }
-  if (enable) {
-    infolist_label_->set_background(
-        views::Background::CreateSolidBackground(kSelectedRowFrameColor));
-  } else {
-    infolist_label_->set_background(NULL);
-  }
-  if (infolist_icon_enabled_ != enable) {
-    SchedulePaint();
-  }
   infolist_icon_enabled_ = enable;
+  infolist_label_->set_background(enable ?
+      views::Background::CreateSolidBackground(kSelectedRowFrameColor) : NULL);
+  UpdateLabelBackgroundColors();
+  SchedulePaint();
 }
 
 void CandidateView::Select() {
   set_background(
       views::Background::CreateSolidBackground(kSelectedRowBackgroundColor));
   set_border(views::Border::CreateSolidBorder(1, kSelectedRowFrameColor));
+  UpdateLabelBackgroundColors();
   // Need to call SchedulePaint() for background and border color changes.
   SchedulePaint();
 }
 
 void CandidateView::Unselect() {
   set_background(NULL);
   set_border(NULL);
+  UpdateLabelBackgroundColors();
   SchedulePaint();  // See comments at Select().
 }
 
 void CandidateView::SetRowEnabled(bool enabled) {
-  shortcut_label_->SetColor(
-      enabled ? kShortcutColor : kDisabledShortcutColor);
+  shortcut_label_->SetEnabled(enabled);
 }
 
 gfx::Point CandidateView::GetCandidateLabelPosition() const {
   return candidate_label_->GetMirroredPosition();
 }
 
 bool CandidateView::OnMousePressed(const views::MouseEvent& event) {
   // TODO(kinaba): investigate a way to delay the commit until OnMouseReleased.
   // Mouse-down selection is a temporally workaround for crosbug.com/11423.
   //
@@ skipping 29 matching lines @@
   // when a popup window gets hidden. http://crosbug.com/11422
 
   gfx::Point location_in_candidate_window = event.location();
   views::View::ConvertPointToView(this, parent_candidate_window_,
                                   &location_in_candidate_window);
   parent_candidate_window_->OnCandidatePressed(location_in_candidate_window);
   parent_candidate_window_->CommitCandidate();
   return false;
 }
 
-CandidateWindowView::CandidateWindowView(
-    views::Widget* parent_frame)
+void CandidateView::UpdateLabelBackgroundColors() {
+  SkColor color = background() ?
+      background()->get_color() : kDefaultBackgroundColor;
+  if (orientation_ != InputMethodLookupTable::kVertical)
+    shortcut_label_->SetBackgroundColor(color);
+  candidate_label_->SetBackgroundColor(color);
+  annotation_label_->SetBackgroundColor(color);
+  if (infolist_label_) {
+    infolist_label_->SetBackgroundColor(infolist_label_->background() ?
+        infolist_label_->background()->get_color() : color);
+  }
+}
+
+CandidateWindowView::CandidateWindowView(views::Widget* parent_frame)
     : selected_candidate_index_in_page_(0),
       parent_frame_(parent_frame),
       preedit_area_(NULL),
       header_area_(NULL),
       candidate_area_(NULL),
       footer_area_(NULL),
       previous_shortcut_column_width_(0),
       previous_candidate_column_width_(0),
       previous_annotation_column_width_(0) {
 }
@@ skipping 126 matching lines @@
     }
 
     // Update the candidates in the current page.
     const size_t start_from = current_page_index * new_lookup_table.page_size;
 
     // In some cases, engines send empty shortcut labels. For instance,
     // ibus-mozc sends empty labels when they show suggestions. In this
     // case, we should not show shortcut labels.
     const bool no_shortcut_mode =
         (start_from < new_lookup_table.labels.size() &&
-         new_lookup_table.labels[start_from] == "");
+         new_lookup_table.labels[start_from].empty());
     for (size_t i = 0; i < candidate_views_.size(); ++i) {
       const size_t index_in_page = i;
       const size_t candidate_index = start_from + index_in_page;
       CandidateView* candidate_view = candidate_views_[index_in_page];
       // Set the shortcut text.
       if (no_shortcut_mode) {
-        candidate_view->SetShortcutText(L"");
+        candidate_view->SetShortcutText(string16());
       } else {
         // At this moment, we don't use labels sent from engines for UX
         // reasons. First, we want to show shortcut labels in empty rows
         // (ex. show 6, 7, 8, ... in empty rows when the number of
         // candidates is 5). Second, we want to add a period after each
         // shortcut label when the candidate window is horizontal.
         candidate_view->SetShortcutText(
             CreateShortcutText(i, new_lookup_table.orientation));
       }
       // Set the candidate text.
       if (candidate_index < new_lookup_table.candidates.size() &&
           candidate_index < new_lookup_table.annotations.size()) {
         candidate_view->SetCandidateText(
-            UTF8ToWide(new_lookup_table.candidates[candidate_index]));
+            UTF8ToUTF16(new_lookup_table.candidates[candidate_index]));
         candidate_view->SetAnnotationText(
-            UTF8ToWide(new_lookup_table.annotations[candidate_index]));
+            UTF8ToUTF16(new_lookup_table.annotations[candidate_index]));
         candidate_view->SetRowEnabled(true);
 
         if ((new_lookup_table.mozc_candidates.candidate_size() >
                  static_cast<int>(i)) &&
             (new_lookup_table.mozc_candidates.
                  candidate(i).has_information_id())) {
           candidate_view->SetInfolistIcon(true);
         } else {
           candidate_view->SetInfolistIcon(false);
         }
       } else {
         // Disable the empty row.
-        candidate_view->SetCandidateText(L"");
-        candidate_view->SetAnnotationText(L"");
+        candidate_view->SetCandidateText(string16());
+        candidate_view->SetAnnotationText(string16());
         candidate_view->SetRowEnabled(false);
         candidate_view->SetInfolistIcon(false);
       }
     }
   }
   // Update the current lookup table. We'll use lookup_table_ from here.
   // Note that SelectCandidateAt() uses lookup_table_.
   lookup_table_ = new_lookup_table;
 
   // Select the current candidate in the page.
@@ skipping 249 matching lines @@
 
   // Initialize the column set with three columns.
   views::ColumnSet* column_set = layout->AddColumnSet(0);
   column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL,
                          0, views::GridLayout::FIXED, 200, 0);
 
   layout->StartRow(0, 0);
   layout->AddView(wrapped_title_label);
   layout->StartRow(0, 0);
   layout->AddView(wrapped_description_label);
+  UpdateLabelBackgroundColors();
 }
 
 
 void InfolistView::SetTitleText(const std::wstring& text) {
   title_label_->SetText(WideToUTF16Hack(text));
 }
 
 void InfolistView::SetDescriptionText(const std::wstring& text) {
   description_label_->SetText(WideToUTF16Hack(text));
 }
 
 void InfolistView::Select() {
-  set_background(
-      views::Background::CreateSolidBackground(
-          kSelectedInfolistRowBackgroundColor));
+  set_background(views::Background::CreateSolidBackground(
+      kSelectedInfolistRowBackgroundColor));
   set_border(
       views::Border::CreateSolidBorder(1, kSelectedInfolistRowFrameColor));
+  UpdateLabelBackgroundColors();
   // Need to call SchedulePaint() for background and border color changes.
   SchedulePaint();
 }
 
 void InfolistView::Unselect() {
   set_background(NULL);
   set_border(NULL);
+  UpdateLabelBackgroundColors();
   SchedulePaint();  // See comments at Select().
 }
 
-InfolistWindowView::InfolistWindowView(
-    views::Widget* parent_frame, views::Widget* candidate_window_frame)
+void InfolistView::UpdateLabelBackgroundColors() {
+  SkColor color = background() ?
+      background()->get_color() : kDefaultBackgroundColor;
+  title_label_->SetBackgroundColor(color);
+  description_label_->SetBackgroundColor(color);
+}
+
+InfolistWindowView::InfolistWindowView(views::Widget* parent_frame,
+                                       views::Widget* candidate_window_frame)
     : parent_frame_(parent_frame),
       candidate_window_frame_(candidate_window_frame),
       infolist_area_(NULL),
       visible_(false) {
 }
 
 InfolistWindowView::~InfolistWindowView() {
   if (infolist_area_ != NULL) {
     infolist_area_->RemoveAllChildViews(false);
   }
@@ skipping 23 matching lines @@
   views::Label* caption_label = NULL;
   caption_label = new views::Label;
   caption_label->SetFont(caption_label->font().DeriveFont(kFontSizeDelta - 2));
   caption_label->SetHorizontalAlignment(views::Label::ALIGN_LEFT);
   caption_label->SetText(
       l10n_util::GetStringUTF16(IDS_INPUT_METHOD_INFOLIST_WINDOW_TITLE));
   views::View* wrapped_caption_label =
       WrapWithPadding(caption_label, gfx::Insets(2, 2, 2, 2));
   wrapped_caption_label->set_background(
       views::Background::CreateSolidBackground(kInfolistTitleBackgroundColor));
+  caption_label->SetBackgroundColor(
+      wrapped_caption_label->background()->get_color());
   layout->AddView(wrapped_caption_label);
 
   layout->StartRow(0, 0);
   layout->AddView(infolist_area_);  // |infolist_area_| is owned by |this|.
 }
 
 void InfolistWindowView::Hide() {
   visible_ = false;
   show_hide_timer_.Stop();
   parent_frame_->Hide();
@@ skipping 300 matching lines @@
 CandidateWindowController::~CandidateWindowController() {
   delete impl_;
 }
 
 bool CandidateWindowController::Init() {
   return impl_->Init();
 }
 
 }  // namespace input_method
 }  // namespace chromeos