Add Content-security-policy to chrome://imageburner

Add Content-security-policy to chrome://imageburner
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105326

[Tom Sepez, 2011-10-10 21:51:20]

Imageburner.  Thanks.

[abarth-chromium, 2011-10-10 22:05:28]

LGTM.  Are you able to test these to make sure they still work after your patch?

[achuithb, 2011-10-10 22:09:32]

LGTM

[Tom Sepez, 2011-10-10 22:14:05]

Testing by building locally with chromeos=1 and ensuring that the page looks the
same as before the change, and that there are no JS errors reported.  This seems
like the limit with the chromeos stub library on Linux.

[abarth-chromium, 2011-10-10 22:18:04]

Ok.  :)

On Mon, Oct 10, 2011 at 3:14 PM,  <tsepez@chromium.org> wrote:
> Testing by building locally with chromeos=1 and ensuring that the page looks
> the
> same as before the change, and that there are no JS errors reported.  This
> seems
> like the limit with the chromeos stub library on Linux.
>
> http://codereview.chromium.org/8221023/
>

[tbarzic, 2011-10-10 22:19:13]

LGTM

On 2011/10/10 22:18:04, abarth wrote:
> Ok.  :)
> 
> On Mon, Oct 10, 2011 at 3:14 PM,  <mailto:tsepez@chromium.org> wrote:
> > Testing by building locally with chromeos=1 and ensuring that the page looks
> > the
> > same as before the change, and that there are no JS errors reported.
&nbsp;This
> > seems
> > like the limit with the chromeos stub library on Linux.
> >
> > http://codereview.chromium.org/8221023/
> >

[achuithb, 2011-10-10 22:20:06]

Toni (tbarzic) wrote most of this code, so hopefully he'll run it on the device
at some point to make sure everything's working.

[tbarzic, 2011-10-10 22:28:37]

On 2011/10/10 22:20:06, achuith.bhandarkar wrote:
> Toni (tbarzic) wrote most of this code, so hopefully he'll run it on the
device
> at some point to make sure everything's working.

Yeah, I'll probably check it during this week..

[Evan Stade, 2011-10-11 21:35:23]

lgtm

Tom, you can ignore all the comments on the js/html files.

http://codereview.chromium.org/8221023/diff/1/chrome/browser/resources/image_...
File chrome/browser/resources/image_burner.html (right):

http://codereview.chromium.org/8221023/diff/1/chrome/browser/resources/image_...
chrome/browser/resources/image_burner.html:7: html, body, ul, li {
tbarzic, at some point please pull this into a separate css file

http://codereview.chromium.org/8221023/diff/1/chrome/browser/resources/image_...
chrome/browser/resources/image_burner.html:76: .float-start {
css classes should line up with the logical use of the element, not the
properties within the rule block.

http://codereview.chromium.org/8221023/diff/1/chrome/browser/resources/image_...
File chrome/browser/resources/image_burner.js (right):

http://codereview.chromium.org/8221023/diff/1/chrome/browser/resources/image_...
chrome/browser/resources/image_burner.js:160: radioButton.type = 'radio';
all of this would (probably) be easier to read if you used a template, i.e.
define it in html like

<li>
  <input name='device' class='float-start'>
  <p class='select-option float-start'></p>
  ...

then cloning that node here.

http://codereview.chromium.org/8221023/diff/1/chrome/browser/resources/image_...
chrome/browser/resources/image_burner.js:173: element.id = 'select ' +
device.devicePath;
an id with a space? Even if it works, it's out of spec:
http://www.w3.org/TR/html5/elements.html#the-id-attribute

http://codereview.chromium.org/8221023/diff/1/chrome/browser/resources/image_...
chrome/browser/resources/image_burner.js:262: deviceAdded: function(device) {
every one of these functions and parameters should be documented.

http://codereview.chromium.org/8221023/diff/1/chrome/browser/resources/image_...
chrome/browser/resources/image_burner.js:316: reportDeviceTooSmall:
function(device_size) {
deviceSize

http://codereview.chromium.org/8221023/diff/1/chrome/browser/ui/webui/chromeo...
File chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc (right):

http://codereview.chromium.org/8221023/diff/1/chrome/browser/ui/webui/chromeo...
chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc:31: static const
char kPropertyDevicePath[] = "devicePath";
do not need static for things in unnamed namespace

[Tom Sepez, 2011-10-13 17:22:21]

Quick re-run of the red linux_chromeos test:
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds...