webkit/tools/test_shell/simple_resource_loader_bridge.cc - Issue 8221021: Modify WaitableEvent::Wait() to return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/tools/test_shell/simple_resource_loader_bridge.cc

Issue 8221021: Modify WaitableEvent::Wait() to return void (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix test Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/tools/test_shell/simple_resource_loader_bridge.cc

diff --git a/webkit/tools/test_shell/simple_resource_loader_bridge.cc b/webkit/tools/test_shell/simple_resource_loader_bridge.cc

index 73fd0cb883ffc9734cc2e05cd8f04be09e1ea2cf..f57406ecb72ac0844157744bb59626bf83c34851 100644

--- a/webkit/tools/test_shell/simple_resource_loader_bridge.cc

+++ b/webkit/tools/test_shell/simple_resource_loader_bridge.cc

@@ -688,8 +688,7 @@ class SyncRequestProxy : public RequestProxy {

}

void WaitForCompletion() {

- if (!event_.Wait())

- NOTREACHED();

+ event_.Wait();

}

// --------------------------------------------------------------------------

@@ -879,8 +878,7 @@ class CookieGetter : public base::RefCountedThreadSafe<CookieGetter> {

}

std::string GetResult() {

- if (!event_.Wait())

- NOTREACHED();

+ event_.Wait();

return result_;

}