WebUI TaskManager: Turn it on-by-default on Win/Mac/Linux

WebUI TaskManager: Turn it on-by-default on Win/Mac/Linux

Modified gyp to define WEBUI_TASK_MANAGER=1.
And fixed some tests, because they had failed with WEBUI_TASK_MANAGER=1 on Windows.

BUG=99029
TEST=manual, trybots pass


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106040

[mazda, 2011-10-10 23:58:46]

http://codereview.chromium.org/8221018/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8221018/diff/1/build/common.gypi#newcode146
build/common.gypi:146: # Disable WebUI TaskManager by default.
Disable -> Enalbe

http://codereview.chromium.org/8221018/diff/1/build/common.gypi#newcode317
build/common.gypi:317: # Enable WebUI TaskManager only on Chrome OS, Touch or
PureView.
only -> always ?

http://codereview.chromium.org/8221018/diff/1/chrome/browser/task_manager/tas...
File chrome/browser/task_manager/task_manager_browsertest.cc (right):

http://codereview.chromium.org/8221018/diff/1/chrome/browser/task_manager/tas...
chrome/browser/task_manager/task_manager_browsertest.cc:340: LOG(INFO) <<
"loading extension";
Are these LOG(INFO) added intentionally?
If not, please remove them.

[yoshiki, 2011-10-11 00:09:09]

Thank you for review!

http://codereview.chromium.org/8221018/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8221018/diff/1/build/common.gypi#newcode146
build/common.gypi:146: # Disable WebUI TaskManager by default.
On 2011/10/10 23:58:46, mazda wrote:
> Disable -> Enalbe

Done.

http://codereview.chromium.org/8221018/diff/1/build/common.gypi#newcode317
build/common.gypi:317: # Enable WebUI TaskManager only on Chrome OS, Touch or
PureView.
On 2011/10/10 23:58:46, mazda wrote:
> only -> always ?

Done.

http://codereview.chromium.org/8221018/diff/1/chrome/browser/task_manager/tas...
File chrome/browser/task_manager/task_manager_browsertest.cc (right):

http://codereview.chromium.org/8221018/diff/1/chrome/browser/task_manager/tas...
chrome/browser/task_manager/task_manager_browsertest.cc:340: LOG(INFO) <<
"loading extension";
On 2011/10/10 23:58:46, mazda wrote:
> Are these LOG(INFO) added intentionally?
> If not, please remove them.

Done.

[mazda, 2011-10-11 00:13:05]

lgtm

[commit-bot: I haz the power, 2011-10-11 00:22:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/8221018/4002

[commit-bot: I haz the power, 2011-10-11 11:42:02]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is win_rel, revision is 104882, job name
was 8221018-4002 (retry) (retry) (retry) (retry).

[commit-bot: I haz the power, 2011-10-18 04:59:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/8221018/4002

[commit-bot: I haz the power, 2011-10-18 07:05:18]

Change committed as 106040