Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: src/variables.cc

Issue 8221004: Move declaration of SerializedScopeInfo from variables.h to objects.h (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 19 matching lines...) Expand all
30 #include "ast.h" 30 #include "ast.h"
31 #include "scopes.h" 31 #include "scopes.h"
32 #include "variables.h" 32 #include "variables.h"
33 33
34 namespace v8 { 34 namespace v8 {
35 namespace internal { 35 namespace internal {
36 36
37 // ---------------------------------------------------------------------------- 37 // ----------------------------------------------------------------------------
38 // Implementation Variable. 38 // Implementation Variable.
39 39
40 const char* Variable::Mode2String(Mode mode) { 40 const char* Variable::Mode2String(VariableMode mode) {
41 switch (mode) { 41 switch (mode) {
42 case VAR: return "VAR"; 42 case VAR: return "VAR";
43 case CONST: return "CONST"; 43 case CONST: return "CONST";
44 case LET: return "LET"; 44 case LET: return "LET";
45 case DYNAMIC: return "DYNAMIC"; 45 case DYNAMIC: return "DYNAMIC";
46 case DYNAMIC_GLOBAL: return "DYNAMIC_GLOBAL"; 46 case DYNAMIC_GLOBAL: return "DYNAMIC_GLOBAL";
47 case DYNAMIC_LOCAL: return "DYNAMIC_LOCAL"; 47 case DYNAMIC_LOCAL: return "DYNAMIC_LOCAL";
48 case INTERNAL: return "INTERNAL"; 48 case INTERNAL: return "INTERNAL";
49 case TEMPORARY: return "TEMPORARY"; 49 case TEMPORARY: return "TEMPORARY";
50 } 50 }
51 UNREACHABLE(); 51 UNREACHABLE();
52 return NULL; 52 return NULL;
53 } 53 }
54 54
55 55
56 Variable::Variable(Scope* scope, 56 Variable::Variable(Scope* scope,
57 Handle<String> name, 57 Handle<String> name,
58 Mode mode, 58 VariableMode mode,
59 bool is_valid_LHS, 59 bool is_valid_LHS,
60 Kind kind) 60 Kind kind)
61 : scope_(scope), 61 : scope_(scope),
62 name_(name), 62 name_(name),
63 mode_(mode), 63 mode_(mode),
64 kind_(kind), 64 kind_(kind),
65 location_(UNALLOCATED), 65 location_(UNALLOCATED),
66 index_(-1), 66 index_(-1),
67 local_if_not_shadowed_(NULL), 67 local_if_not_shadowed_(NULL),
68 is_valid_LHS_(is_valid_LHS), 68 is_valid_LHS_(is_valid_LHS),
69 is_accessed_from_inner_scope_(false), 69 is_accessed_from_inner_scope_(false),
70 is_used_(false) { 70 is_used_(false) {
71 // names must be canonicalized for fast equality checks 71 // names must be canonicalized for fast equality checks
72 ASSERT(name->IsSymbol()); 72 ASSERT(name->IsSymbol());
73 } 73 }
74 74
75 75
76 bool Variable::is_global() const { 76 bool Variable::is_global() const {
77 // Temporaries are never global, they must always be allocated in the 77 // Temporaries are never global, they must always be allocated in the
78 // activation frame. 78 // activation frame.
79 return mode_ != TEMPORARY && scope_ != NULL && scope_->is_global_scope(); 79 return mode_ != TEMPORARY && scope_ != NULL && scope_->is_global_scope();
80 } 80 }
81 81
82 } } // namespace v8::internal 82 } } // namespace v8::internal
OLDNEW
« src/parser.cc ('K') | « src/variables.h ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698