Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 8221004: Move declaration of SerializedScopeInfo from variables.h to objects.h (Closed)

Created:
9 years, 2 months ago by fschneider
Modified:
9 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Move declaration of SerializedScopeInfo from variables.h to objects.h This eliminates compile-errors when assigning Handle<SerializedScopeInfo> to Handle<Object> in a place where the declaration was not available because variables.h was not included. As a result I had to also move the enum Variable::Mode to v8globals.h and rename it to VariableMode. Committed: http://code.google.com/p/v8/source/detail?r=9575

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -273 lines) Patch
M src/arm/full-codegen-arm.cc View 11 chunks +18 lines, -20 lines 0 comments Download
M src/ast.h View 1 chunk +5 lines, -7 lines 0 comments Download
M src/contexts.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 12 chunks +19 lines, -21 lines 0 comments Download
M src/objects.h View 1 chunk +62 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 13 chunks +19 lines, -26 lines 4 comments Download
M src/scopeinfo.h View 5 chunks +8 lines, -71 lines 0 comments Download
M src/scopeinfo.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M src/scopes.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/scopes.cc View 17 chunks +25 lines, -27 lines 0 comments Download
M src/v8globals.h View 3 chunks +31 lines, -2 lines 0 comments Download
M src/variables.h View 4 chunks +4 lines, -32 lines 0 comments Download
M src/variables.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 12 chunks +18 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fschneider
9 years, 2 months ago (2011-10-10 14:17:21 UTC) #1
Yang
On 2011/10/10 14:17:21, fschneider wrote: LGTM with comments.
9 years, 2 months ago (2011-10-11 07:56:21 UTC) #2
Yang
LGTM with comments. http://codereview.chromium.org/8221004/diff/1/src/parser.cc File src/parser.cc (left): http://codereview.chromium.org/8221004/diff/1/src/parser.cc#oldcode1691 src/parser.cc:1691: Scope* declaration_scope = mode == Variable::LET ...
9 years, 2 months ago (2011-10-11 07:56:35 UTC) #3
fschneider
9 years, 2 months ago (2011-10-11 11:04:22 UTC) #4
http://codereview.chromium.org/8221004/diff/1/src/parser.cc
File src/parser.cc (left):

http://codereview.chromium.org/8221004/diff/1/src/parser.cc#oldcode1691
src/parser.cc:1691: Scope* declaration_scope = mode == Variable::LET
On 2011/10/11 07:56:35, Yang wrote:
> Consider adding brackets here for better readability.

Done.

http://codereview.chromium.org/8221004/diff/1/src/parser.cc#oldcode1882
src/parser.cc:1882: bool in_with = mode == Variable::VAR ? inside_with() :
false;
On 2011/10/11 07:56:35, Yang wrote:
> Consider brackets.

Done.

Powered by Google App Engine
This is Rietveld 408576698