Remove the unused source_net_log parameter from ResolveHelper.

Remove the unused source_net_log parameter from ResolveHelper.  This
also fixes the wrong argument order in one of the ResolveHelper calls.

This bug was introduced in http://codereview.chromium.org/7492059/.

R=cbentzel@chromium.org,eroman@chromium.org
BUG=100080
TEST=net_unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105184

[wtc, 2011-10-11 21:24:18]

http://codereview.chromium.org/8220028/diff/3001/net/base/host_resolver_impl.cc
File net/base/host_resolver_impl.cc (left):

http://codereview.chromium.org/8220028/diff/3001/net/base/host_resolver_impl....
net/base/host_resolver_impl.cc:1350:
request_net_log.AddEvent(NetLog::TYPE_HOST_RESOLVER_IMPL_CACHE_HIT, NULL);

Note that in the original code, Resolve passes source_net_log
and request_net_log to ResolveHelper in the wrong order.

The consequence of this bug is that the
NetLog::TYPE_HOST_RESOLVER_IMPL_CACHE_HIT event here is
added to the wrong net log (actually source_net_log)
when Resolve is called.

[wtc, 2011-10-11 21:30:09]

http://codereview.chromium.org/8220028/diff/3001/net/base/host_resolver_impl.cc
File net/base/host_resolver_impl.cc (left):

http://codereview.chromium.org/8220028/diff/3001/net/base/host_resolver_impl....
net/base/host_resolver_impl.cc:1350:
request_net_log.AddEvent(NetLog::TYPE_HOST_RESOLVER_IMPL_CACHE_HIT, NULL);

I forgot to mention that the original code before
http://codereview.chromium.org/7492059/ also added this
event to request_net_log.  See
http://codereview.chromium.org/7492059/diff/21034/net/base/host_resolver_impl...

This is why I concluded request_net_log is the intended net
log for ServeFromCache and ResolveHelper.

[eroman, 2011-10-12 00:48:06]

lgtm, good find!

Regarding the bug numbers on this CL: I don't think they should reference the
old bugs, but rather a new bug describing the regression.

[cbentzel, 2011-10-12 15:20:18]

LGTM

Thanks for tracking this down and fixing it.

[wtc, 2011-10-12 18:58:07]

On 2011/10/12 00:48:06, eroman wrote:
>
> Regarding the bug numbers on this CL: I don't think they should reference the
> old bugs, but rather a new bug describing the regression.

Filed bug 100080 and submitted the CL to the commit queue.

[commit-bot: I haz the power, 2011-10-12 18:58:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/8220028/3001

[commit-bot: I haz the power, 2011-10-12 22:38:01]

Change committed as 105184