Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7320)

Unified Diff: chrome/browser/ui/webui/constrained_html_ui.h

Issue 8220026: Add new methods to create constrained windows for print preview and release the internal TabConte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rename Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/constrained_html_ui.h
===================================================================
--- chrome/browser/ui/webui/constrained_html_ui.h (revision 105522)
+++ chrome/browser/ui/webui/constrained_html_ui.h (working copy)
@@ -23,6 +23,20 @@
// Called when the dialog is being closed in response to a "DialogClose"
// message from WebUI.
virtual void OnDialogCloseFromWebUI() = 0;
+
+ // If called, on dialog closure, the dialog will release its TabContents
+ // instead of destroying it. After which point, the caller will own the
+ // released TabContents.
+ virtual void ReleaseTabContentsOnDialogClose() = 0;
+
+ // Returns the ConstrainedWindow.
+ virtual ConstrainedWindow* window() = 0;
+
+ // Returns the TabContentsWrapper owned by the constrained window.
+ virtual TabContentsWrapper* tab() = 0;
+
+ protected:
+ virtual ~ConstrainedHtmlUIDelegate() {}
};
// ConstrainedHtmlUI is a facility to show HTML WebUI content
@@ -41,7 +55,7 @@
// Create a constrained HTML dialog. The actual object that gets created
// is a ConstrainedHtmlUIDelegate, which later triggers construction of a
// ConstrainedHtmlUI object.
- static ConstrainedWindow* CreateConstrainedHtmlDialog(
+ static ConstrainedHtmlUIDelegate* CreateConstrainedHtmlDialog(
Profile* profile,
HtmlDialogUIDelegate* delegate,
TabContentsWrapper* overshadowed);
« no previous file with comments | « chrome/browser/ui/views/constrained_html_delegate_views.cc ('k') | chrome/browser/ui/webui/constrained_html_ui_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698