Add new methods to create constrained windows for print preview and release the internal TabConte...

chrome/browser/ui/webui/constrained_html_ui.h

Index: chrome/browser/ui/webui/constrained_html_ui.h
===================================================================
--- chrome/browser/ui/webui/constrained_html_ui.h	(revision 104824)
+++ chrome/browser/ui/webui/constrained_html_ui.h	(working copy)
@@ -23,6 +23,14 @@
   // Called when the dialog is being closed in response to a "DialogClose"
   // message from WebUI.
   virtual void OnDialogCloseFromWebUI() = 0;
+
+  // If called, on dialog closure, the dialog will release its TabContents
+  // instead of destroying it. After which point, the caller will own the
+  // released TabContents.
+  virtual void ReleaseTabContentsOnDialogClose() = 0;

[Evan Stade, 2011/10/11 02:49:17]

what is the point of this? seems like it's only used in a test

[Lei Zhang, 2011/10/11 03:15:58]

I'm splitting this chunk of code into a separate CL to avoid a 40 file CL. It
will be used for print preview, but in this CL there's only a test to exercise
it. I'd highly prefer not to have 20 patch sets and 10 reviewers.

[Evan Stade, 2011/10/11 22:54:59]

it's impossible for me to review a design without a use case that exercises it,
but I do agree that smaller CLs are better than bigger ones. Thus I suggest that
you create the minimal CL which actually makes use of this function.

[Lei Zhang, 2011/10/11 23:04:57]

Sorry, much of the bigger CL is monolithic. You can look at it though:
http://codereview.chromium.org/8136027/

The use case is as follows:
- user presses print
- the constrained window needs to go away
- the print preview TabContents (in the constrained window) needs to stay alive
until it finishes printing

So what we do is:
- BackgroundPrintingManager takes ownership of the PP TabContents. Holds on to
it until printing finishes.
- Tell the constrained window to "ReleaseTabContentsOnDialogClose"
- Close the constrained window

+
+ protected:
+  virtual ~ConstrainedHtmlUIDelegate() {}
 };
 
 // ConstrainedHtmlUI is a facility to show HTML WebUI content
@@ -46,12 +54,23 @@
       HtmlDialogUIDelegate* delegate,
       TabContentsWrapper* overshadowed);
 
+  // Similar to CreateConstrainedHtmlDialog() but specifically for print
+  // preview, where we care about the constrained TabContentsWrapper rather
+  // than the ConstrainedWindow.
+  static TabContentsWrapper* CreateConstrainedPrintPreviewHtmlUI(
+      Profile* profile,
+      HtmlDialogUIDelegate* delegate,
+      TabContentsWrapper* overshadowed);
+
   // Returns a property accessor that can be used to set the
   // ConstrainedHtmlUIDelegate property on a TabContents.
   static PropertyAccessor<ConstrainedHtmlUIDelegate*>&
       GetPropertyAccessor();
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(ConstrainedHtmlDialogBrowserTest,
+                           ReleaseTabContentsOnDialogClose);
+
   // Returns the TabContents' PropertyBag's ConstrainedHtmlUIDelegate.
   // Returns NULL if that property is not set.
   ConstrainedHtmlUIDelegate* GetConstrainedDelegate();