Add new methods to create constrained windows for print preview and release the internal TabConte...

chrome/browser/ui/login/login_prompt_ui.cc

Index: chrome/browser/ui/login/login_prompt_ui.cc
===================================================================
--- chrome/browser/ui/login/login_prompt_ui.cc	(revision 105278)
+++ chrome/browser/ui/login/login_prompt_ui.cc	(working copy)
@@ -58,7 +58,7 @@
 
   static void RegisterDataSource(Profile *profile) {
     ChromeURLDataManager* url_manager = profile->GetChromeURLDataManager();
-    LoginHandlerSource *source = new LoginHandlerSource();
+    LoginHandlerSource* source = new LoginHandlerSource();
     url_manager->AddDataSource(source);
   }
 
@@ -141,7 +141,7 @@
     SendAutofillData();
   }
 
-  LoginHandlerHtml *login_handler_;
+  LoginHandlerHtml* login_handler_;
   std::string explanation_;
   bool closed_;
 
@@ -180,7 +180,7 @@
   virtual ~LoginHandlerHtml() {}
 
  private:
-  LoginHandlerHtmlDelegate *delegate_;
+  LoginHandlerHtmlDelegate* delegate_;
 
   void FreeAndRelease() {
     SetDialog(NULL);
@@ -245,8 +245,10 @@
   Profile* profile = wrapper->profile();
   LoginHandlerSource::RegisterDataSource(profile);
   delegate_ = new LoginHandlerHtmlDelegate(this, explanation);
-  ConstrainedWindow* dialog = ConstrainedHtmlUI::CreateConstrainedHtmlDialog(
-      profile, delegate_, wrapper);
+  ConstrainedHtmlUIDelegate* html_ui_delegate =
+      ConstrainedHtmlUI::CreateConstrainedHtmlDialog(profile, delegate_,
+                                                     wrapper);

[Evan Stade, 2011/10/13 23:59:14]

nit: don't need to store delegate variable

[Lei Zhang, 2011/10/14 17:31:05]

As in you prefer:

ConstrainedWindow* dialog =
ConstrainedHtmlUI::CreateConstrainedHtmlDialog(profile, delegate_,
wrapper)->window(); ?

or did you mean no need for |dialog| ?

+  ConstrainedWindow* dialog = html_ui_delegate->window();
 
   SetModel(manager);
   SetDialog(dialog);