Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: base/message_pump_glib.h

Issue 8220: Own the GLib poll FD; it should not be on the stack. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/message_pump_glib.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_pump_glib.h
===================================================================
--- base/message_pump_glib.h (revision 4621)
+++ base/message_pump_glib.h (working copy)
@@ -91,6 +91,8 @@
// The work source. It is shared by all calls to Run and destroyed when
// the message pump is destroyed.
GSource* work_source_;
+ // The GLib poll structure needs to be owned and freed by us.
+ GPollFD* work_source_poll_info_;
Evan Martin 2008/11/04 21:25:58 could it be a scoped_ptr? not sure that "info" add
DISALLOW_COPY_AND_ASSIGN(MessagePumpForUI);
};
« no previous file with comments | « no previous file | base/message_pump_glib.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698