Issue 8220: Own the GLib poll FD; it should not be on the stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8220: Own the GLib poll FD; it should not be on the stack. (Closed)

Created:
12 years, 1 month ago by dsh

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, evanm, Evan Martin

CC:
chromium-reviews_googlegroups.com, dsh

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4698

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	base/message_pump_glib.h	View		1 chunk	+2 lines, -0 lines	1 comment	Download
	M	base/message_pump_glib.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dsh

GLib does not make a copy of the PollFD struct, so it should not be ...

12 years, 1 month ago (2008-11-04 20:48:26 UTC) #1

Evan Martin

12 years, 1 month ago (2008-11-04 21:25:57 UTC) #3

LGTM, minor suggestions for you to consider

http://codereview.chromium.org/8220/diff/1/2
File base/message_pump_glib.h (right):

http://codereview.chromium.org/8220/diff/1/2#newcode95
Line 95: GPollFD* work_source_poll_info_;
could it be a scoped_ptr?
not sure that "info" adds much description to the name.  could just stuff "fd"
in there in place of info...

Expand Messages | Collapse Messages