Issue 8217011: Fixing issue 1757 (string slices of external strings).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8217011: Fixing issue 1757 (string slices of external strings). (Closed)

Created:
9 years, 2 months ago by Yang

Modified:
9 years, 2 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fixing issue 1757 (string slices of external strings). BUG=v8:1757 TEST=regress-1757.js Committed: http://code.google.com/p/v8/source/detail?r=9573

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -14 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
A	test/mjsunit/regress/regress-1757.js	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Yang

The problem was cause by object_ being changed before bailing out to runtime. Therefore a ...

9 years, 2 months ago (2011-10-10 15:56:15 UTC) #1

LGTM.