Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 8216009: Use TYPED PageTransition for Omnibox prerendering. (Closed)

Created:
9 years, 2 months ago by dominich
Modified:
9 years, 2 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke
Visibility:
Public.

Description

Use TYPED PageTransition for Omnibox prerendering. BUG=99542, 99016 TEST=UnitTest: Prerender*, BrowserTest: Prerender* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104756

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/prerender/prerender_contents.cc View 1 chunk +6 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
dominich
9 years, 2 months ago (2011-10-10 15:53:22 UTC) #1
cbentzel
LGTM http://codereview.chromium.org/8216009/diff/1/chrome/browser/prerender/prerender_contents.cc File chrome/browser/prerender/prerender_contents.cc (right): http://codereview.chromium.org/8216009/diff/1/chrome/browser/prerender/prerender_contents.cc#newcode323 chrome/browser/prerender/prerender_contents.cc:323: if (origin_ == ORIGIN_OMNIBOX_ORIGINAL || Perhaps an IsOmniboxOrigin() ...
9 years, 2 months ago (2011-10-10 15:55:15 UTC) #2
dominich
http://codereview.chromium.org/8216009/diff/1/chrome/browser/prerender/prerender_contents.cc File chrome/browser/prerender/prerender_contents.cc (right): http://codereview.chromium.org/8216009/diff/1/chrome/browser/prerender/prerender_contents.cc#newcode323 chrome/browser/prerender/prerender_contents.cc:323: if (origin_ == ORIGIN_OMNIBOX_ORIGINAL || On 2011/10/10 15:55:15, cbentzel ...
9 years, 2 months ago (2011-10-10 15:57:47 UTC) #3
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/dominich@chromium.org/8216009/1
9 years, 2 months ago (2011-10-10 17:54:29 UTC) #4
commit-bot: I haz the power
9 years, 2 months ago (2011-10-10 19:16:38 UTC) #5
Change committed as 104756

Powered by Google App Engine
This is Rietveld 408576698