Issue 8216005: Make GCC 4.5.x happy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8216005: Make GCC 4.5.x happy. (Closed)

Created:
9 years, 2 months ago by Sven Panne

Modified:
9 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make GCC 4.5.x happy. Committed: http://code.google.com/p/v8/source/detail?r=9555

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/objects.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. http://codereview.chromium.org/8216005/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/8216005/diff/1/src/objects.cc#newcode10530 src/objects.cc:10530: template class HashTable<ObjectHashTableShape, JSObject*>; I think we can ...

9 years, 2 months ago (2011-10-10 08:49:36 UTC) #2

Sven Panne

9 years, 2 months ago (2011-10-10 08:56:53 UTC) #3

http://codereview.chromium.org/8216005/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/8216005/diff/1/src/objects.cc#newcode10530
src/objects.cc:10530: template class HashTable<ObjectHashTableShape, JSObject*>;
On 2011/10/10 08:49:36, Michael Starzinger wrote:
> I think we can remove this instance now.

Done.

Expand Messages | Collapse Messages

Issue 8216005: Make GCC 4.5.x happy. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages