webkit/tools/test_shell/test_shell_devtools_client.h - Issue 8215002: base::Bind: Cleanup in test_shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/tools/test_shell/test_shell_devtools_client.h

Issue 8215002: base::Bind: Cleanup in test_shell. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review fix. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/tools/test_shell/test_shell_devtools_client.h

diff --git a/webkit/tools/test_shell/test_shell_devtools_client.h b/webkit/tools/test_shell/test_shell_devtools_client.h

index af8f41b1ccc6407d856ce514fc0c87c3c6a389af..b9ef29042c26ad14cbf915735d26b89a581f3a87 100644

--- a/webkit/tools/test_shell/test_shell_devtools_client.h

+++ b/webkit/tools/test_shell/test_shell_devtools_client.h

@@ -6,6 +6,7 @@

#define TEST_SHELL_DEVTOOLS_CLIENT_H_

#include "base/memory/scoped_ptr.h"

+#include "base/memory/weak_ptr.h"

#include "base/task.h"

#include "third_party/WebKit/Source/WebKit/chromium/public/WebDevToolsFrontendClient.h"

@@ -44,7 +45,7 @@ class TestShellDevToolsClient: public WebKit::WebDevToolsFrontendClient {

private:

void Call(const TestShellDevToolsCallArgs& args);

- ScopedRunnableMethodFactory<TestShellDevToolsClient> call_method_factory_;

+ base::WeakPtrFactory<TestShellDevToolsClient> weak_factory_;

TestShellDevToolsAgent* dev_tools_agent_;

WebKit::WebView* web_view_;

scoped_ptr<WebKit::WebDevToolsFrontend> web_tools_frontend_;