webkit/tools/test_shell/test_shell_devtools_agent.h - Issue 8215002: base::Bind: Cleanup in test_shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/tools/test_shell/test_shell_devtools_agent.h

Issue 8215002: base::Bind: Cleanup in test_shell. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review fix. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/tools/test_shell/test_shell_devtools_agent.h

diff --git a/webkit/tools/test_shell/test_shell_devtools_agent.h b/webkit/tools/test_shell/test_shell_devtools_agent.h

index ee45ed62c3d81f16f42e4e6735d401d03cb18a8c..92584426f222a258dc7e8ffd9a184fc053a75a74 100644

--- a/webkit/tools/test_shell/test_shell_devtools_agent.h

+++ b/webkit/tools/test_shell/test_shell_devtools_agent.h

@@ -5,6 +5,7 @@

#ifndef TEST_SHELL_DEVTOOLS_AGENT_H_

#define TEST_SHELL_DEVTOOLS_AGENT_H_

+#include "base/memory/weak_ptr.h"

#include "base/task.h"

#include "third_party/WebKit/Source/WebKit/chromium/public/WebDevToolsAgentClient.h"

@@ -51,7 +52,7 @@ class TestShellDevToolsAgent : public WebKit::WebDevToolsAgentClient {

static void DispatchMessageLoop();

WebKit::WebDevToolsAgent* GetWebAgent();

- ScopedRunnableMethodFactory<TestShellDevToolsAgent> call_method_factory_;

+ base::WeakPtrFactory<TestShellDevToolsAgent> weak_factory_;

TestShellDevToolsClient* dev_tools_client_;

int routing_id_;

WebKit::WebDevToolsAgent* web_dev_tools_agent_;