Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: chrome/browser/automation/url_request_automation_job.h

Issue 8212006: base::Bind: Cleanup in automation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Linux test fixes. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/url_request_automation_job.h
diff --git a/chrome/browser/automation/url_request_automation_job.h b/chrome/browser/automation/url_request_automation_job.h
index e9dd127a6914124e5636594d6567907c0b2373c1..096ce06659648a5dd99170ea9a7e1387852c05eb 100644
--- a/chrome/browser/automation/url_request_automation_job.h
+++ b/chrome/browser/automation/url_request_automation_job.h
@@ -7,6 +7,7 @@
#define CHROME_BROWSER_AUTOMATION_URL_REQUEST_AUTOMATION_JOB_H_
#pragma once
+#include "base/memory/weak_ptr.h"
#include "base/task.h"
#include "chrome/common/ref_counted_util.h"
#include "net/url_request/url_request.h"
@@ -34,7 +35,7 @@ class URLRequestAutomationJob : public net::URLRequestJob {
bool is_pending);
// Register our factory for HTTP/HTTPs requests.
- static bool EnsureProtocolFactoryRegistered();
+ static void EnsureProtocolFactoryRegistered();
static net::URLRequest::ProtocolFactory Factory;
@@ -128,7 +129,7 @@ class URLRequestAutomationJob : public net::URLRequestJob {
// Contains the ip address and port of the destination host.
net::HostPortPair socket_address_;
- ScopedRunnableMethodFactory<URLRequestAutomationJob> method_factory_;
+ base::WeakPtrFactory<URLRequestAutomationJob> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(URLRequestAutomationJob);
};

Powered by Google App Engine
This is Rietveld 408576698