[chromiumos] Start TPM token initialization re-tries on login

crypto/nss_util.cc

Index: crypto/nss_util.cc
diff --git a/crypto/nss_util.cc b/crypto/nss_util.cc
index 9020e7eb0a46c3dec04bf4f34c111e3fc1e68b1a..e5dea56486f7464e051766a7bfcd905200c13768 100644
--- a/crypto/nss_util.cc
+++ b/crypto/nss_util.cc
@@ -234,9 +234,6 @@ class NSSInitSingleton {
   void EnableTPMTokenForNSS(TPMTokenInfoDelegate* info_delegate) {
     CHECK(info_delegate);
     tpm_token_info_delegate_.reset(info_delegate);
-    // Try to load once to avoid jank later.  Ignore the return value,
-    // because if it fails we will try again later.
-    EnsureTPMTokenReady();

[stevenjb, 2011/10/10 17:18:13]

Why remove this? If the new logic gets changed, or isn't called (guest mode?
developer testing?) we might still want to initialize the TPM here, and it
shouldn't cost anything if it's already been initialized?

[gauravsh, 2011/10/10 20:55:49]

Is it used anywhere else? I couldn't find it.

The only place EnableTPMTokenForNSS I saw was in user_manager.cc in
NotifyOnLogin(). A call to RequestCertificates() already makes an initial
attempt to call EnsureTPMTokenReady() before posting a delayed task. So this is
redundant. We want to route all calls to this initialization code through
CertLibrary::RequestCertificates() since that handles the re-try part
(EnsureTPMTokenReady() asynchronously checks if the TPM token has been
initialized, it doesn't actually trigger the initialization).

   }
 
   // This is called whenever we want to make sure opencryptoki is