Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 821001: Moved one check outside of the loop and moved another one under an if stateme... (Closed)

Created:
10 years, 9 months ago by sandholm
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Moved one check outside of the loop and moved another one under an if statement Committed: http://code.google.com/p/v8/source/detail?r=4082

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -29 lines) Patch
M src/string.js View 1 1 chunk +54 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sandholm
10 years, 9 months ago (2010-03-10 10:44:25 UTC) #1
Erik Corry
You need to install cpplint.py (it's Open Source) and run tools/presubmit.py. I think it will ...
10 years, 9 months ago (2010-03-10 11:16:43 UTC) #2
sandholm
10 years, 9 months ago (2010-03-10 11:59:25 UTC) #3
http://codereview.chromium.org/821001/diff/1/2
File src/string.js (right):

http://codereview.chromium.org/821001/diff/1/2#newcode392
src/string.js:392: if (NUMBER_OF_CAPTURES(matchInfo) == 2) {
On 2010/03/10 11:16:43, Erik Corry wrote:
> Please add a comment here to say that the loop is substantially the same in
both
> branches of the loop for speed.

Done.

Powered by Google App Engine
This is Rietveld 408576698