Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 8207: Fix SCons modules build on Windows:... (Closed)

Created:
12 years, 2 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
tony, bradn
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix SCons modules build on Windows: * Add 'midl' Tool module. * Filter out the default OS_WINDOWS= definition from the Hammer modules, which messes up our build. * Fix the $PLATFORMSDK_VISTA definition. * Remove the current directory from the 'base' Alias (avoid cycles). * Remove by-hand addition of .lib, .pdb and .ilk files to the target list when build shared libraries (multiple places). * Comment out a post-action Touch() of the themes/default resource. (Thanks to bradnelson for many of the above individual fixes.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -62 lines) Patch
M base/base.scons View 1 chunk +0 lines, -2 lines 0 comments Download
M base/base_unittests.scons View 1 chunk +2 lines, -1 line 0 comments Download
M build/SConscript.main View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/SConscript View 3 chunks +6 lines, -24 lines 0 comments Download
M chrome/SConscript.ui_tests View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/app/theme/SConscript View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/mini_installer/SConscript View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/installer/setup/SConscript View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/test/activex_test_control/SConscript View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/security_tests/SConscript View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sgk
12 years, 2 months ago (2008-10-25 02:34:45 UTC) #1
bradn
LGTM
12 years, 2 months ago (2008-10-25 17:12:13 UTC) #2
tony
12 years, 1 month ago (2008-10-26 03:10:28 UTC) #3
LGTM2

Powered by Google App Engine
This is Rietveld 408576698