Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 8206015: Add StackTrace::ToString(). (Closed)

Created:
9 years, 2 months ago by satorux1
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org
Visibility:
Public.

Description

Add StackTrace::ToString(). This can be used for debug logging like: LOG(ERROR) << base::debug::StackTrace().ToString(); As opposed to std::strstream stream; base::debug::StackTrace().OutputToStream(&stream); LOG(ERROR) << stream.str(); BUG=none TEST=add a test to stack_unitttest and confirm it passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M base/debug/stack_trace.h View 2 chunks +4 lines, -0 lines 0 comments Download
M base/debug/stack_trace.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M base/debug/stack_trace_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
satorux1
9 years, 2 months ago (2011-10-07 21:52:11 UTC) #1
satorux1
Ping. I thought it's a good change. Streams are discouraged by the C++ style guide, ...
9 years, 2 months ago (2011-10-12 05:24:48 UTC) #2
willchan no longer on Chromium
LGTM, sorry, was just slow.
9 years, 2 months ago (2011-10-12 05:30:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/8206015/1
9 years, 2 months ago (2011-10-12 14:51:02 UTC) #4
commit-bot: I haz the power
9 years, 2 months ago (2011-10-12 16:13:41 UTC) #5
Change committed as 105085

Powered by Google App Engine
This is Rietveld 408576698