Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 8206: Update contents_mime_type_ of WebContents only for the main frame. RenderView... (Closed)

Created:
12 years, 2 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com, Mark Larson
Visibility:
Public.

Description

Update contents_mime_type_ of WebContents only for the main frame. RenderView does not set the value for sub frames. As a result, we ended up resetting to NULL by updating it for any frame. This CL should go in for both trunk and 0.3.154.x branch. BUG=2929 TEST=Open http://fund.eastmoney.com in a tab, switch to another tab and then switch back. Encoding menu should be enabled which tab you're in. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4001

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/web_contents.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
12 years, 2 months ago (2008-10-25 02:47:39 UTC) #1
jungshik at Google
12 years, 2 months ago (2008-10-25 02:47:45 UTC) #2

          

Powered by Google App Engine
This is Rietveld 408576698