Issue 8205017: Fix crash when reloading extension with more than one panel open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8205017: Fix crash when reloading extension with more than one panel open. (Closed)

Created:
9 years, 2 months ago by jennb

Modified:
9 years, 2 months ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews, jennb, jianli, dcheng, prasadt

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix crash when reloading extension with more than one panel open. BUG=None TEST=Open an extension that opens 2 or more panels. Reload the extension. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104732

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	chrome/browser/ui/panels/panel_window_controller_cocoa.mm	View		3 chunks	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jennb

The crash was occurring because the panel manager was rearranging the remaining panel after removing ...

9 years, 2 months ago (2011-10-07 23:39:25 UTC) #1

Dmitry Titov

9 years, 2 months ago (2011-10-08 00:01:56 UTC) #2

LGTM

Looks like this might be a simpler fix then figuring out the right moment for
removing the window from PanelManager. It seems PanelManager should operate
freely on windows w/o even knowing that some internals like tabContents is
functional or not... It might be actually the right fix. 

WebKit, for example, has tons of null checks like that everywhere.

Expand Messages | Collapse Messages