(Owner approval for) Delay network requests on startup if any webRequest ...

chrome/common/extensions/extension_permission_set.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_permission_set.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/memory/singleton.h"
@@ skipping 293 matching lines @@
       ExtensionPermissionMessage::kTabs, optional);
   RegisterPermission(
       ExtensionAPIPermission::kTts, "tts", 0,
       ExtensionPermissionMessage::kNone, none);
   RegisterPermission(
       ExtensionAPIPermission::kTtsEngine, "ttsEngine",
       IDS_EXTENSION_PROMPT_WARNING_TTS_ENGINE,
       ExtensionPermissionMessage::kTtsEngine, none);
   RegisterPermission(
       ExtensionAPIPermission::kWebNavigation, "webNavigation",
       IDS_EXTENSION_PROMPT_WARNING_TABS,

[Aaron Boodman, 2011/10/10 22:59:29]

What is the behavior with these two APIs if you have no host permissions. Do
they still give you URLs, or do they do nothing at all?

If the former, the warning you have here is appropriate. If the latter, there
should be no warning.

[Pam (message me for reviews), 2011/10/12 14:28:12]

They'll let you register a listener in any case, but if you don't have host
permission for the site that's generating the event, you won't get a
notification.

(At least, that's the design. For webRequest at least, it's not yet implemented,
but will be before it goes stable.)

Warnings removed.

       ExtensionPermissionMessage::kTabs, none);
   RegisterPermission(
+      ExtensionAPIPermission::kWebRequest, "webRequest",
+      IDS_EXTENSION_PROMPT_WARNING_TABS,
+      ExtensionPermissionMessage::kTabs, none);
+  RegisterPermission(
       ExtensionAPIPermission::kWebSocketProxyPrivate,
       "webSocketProxyPrivate", 0,
       ExtensionPermissionMessage::kNone, none);
 
   // Private permissions
   RegisterPermission(
       ExtensionAPIPermission::kChromeosInfoPrivate, "chromeosInfoPrivate", 0,
       ExtensionPermissionMessage::kNone, component_only);
   RegisterPermission(
       ExtensionAPIPermission::kFileBrowserPrivate, "fileBrowserPrivate", 0,
@@ skipping 510 matching lines @@
   std::set<std::string> new_hosts_set(GetDistinctHosts(new_list, false, false));
   std::set<std::string> old_hosts_set(GetDistinctHosts(old_list, false, false));
   std::set<std::string> new_hosts_only;
 
   std::set_difference(new_hosts_set.begin(), new_hosts_set.end(),
                       old_hosts_set.begin(), old_hosts_set.end(),
                       std::inserter(new_hosts_only, new_hosts_only.begin()));
 
   return !new_hosts_only.empty();
 }