Implement chrome.experimental.downloads.onChanged

chrome/test/data/extensions/api_test/downloads/test.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // downloads api test
 // browser_tests.exe --gtest_filter=DownloadsApiTest.Downloads
 
 var downloads = chrome.experimental.downloads;
 
 chrome.test.getConfig(function(testConfig) {
@@ skipping 31 matching lines @@
 
   // The "/slow" handler waits a specified amount of time before returning a
   // safe file. Specify zero seconds to return quickly.
   var SAFE_FAST_URL = getURL('slow?0');
   var NEVER_FINISH_URL = getURL('download-known-size');
   var ERROR_GENERIC = downloads.ERROR_GENERIC;
   var ERROR_INVALID_URL = downloads.ERROR_INVALID_URL;
   var ERROR_INVALID_OPERATION = downloads.ERROR_INVALID_OPERATION;
 
   chrome.test.runTests([
     // TODO(benjhayden): Test onErased using remove().

[Randy Smith (Not in Mondays), 2012/01/15 18:47:13]

Why not as part of this CL, since it fires the OnErased() notification?

[benjhayden, 2012/02/01 21:42:40]

I need remove() in order to test onErased. I can't test onErased until I can
erase an item.

[Randy Smith (Not in Mondays), 2012/02/02 18:10:06]

*snort*  Right you are.  Who knew?  :-}  (I.e. that's obvious enough I shouldn't
have bothered you with it.  Thanks for the explanation.)

+    function downloadOnChanged() {
+      function myListener(delta) {
+        if (delta.state && delta.state.new == 'complete') {
+          chrome.experimental.downloads.onChanged.removeListener(myListener);
+          chrome.test.succeed();
+        }
+      }
+      chrome.experimental.downloads.onChanged.addListener(myListener);
+      chrome.experimental.downloads.download(
+        {"url": getURL("slow?0")},
+        function(id) {
+          chrome.test.assertEq(getNextId(), id);
+      });
+    },
     function downloadFilename() {
+      function myListener(delta) {
+        if (delta.filename && delta.filename.new.indexOf('/foo') !== -1) {
+          chrome.experimental.downloads.onChanged.removeListener(myListener);
+          chrome.test.succeed();
+        }
+      }
+      chrome.experimental.downloads.onChanged.addListener(myListener);
       downloads.download(
           {'url': SAFE_FAST_URL, 'filename': 'foo'},
-          chrome.test.callbackPass(function(id) {
+          function(id) {
             chrome.test.assertEq(getNextId(), id);
-          }));
-      // TODO(benjhayden): Test the filename using onChanged.
+          });
     },
     function downloadOnCreated() {
       chrome.test.listenOnce(downloads.onCreated,
                              chrome.test.callbackPass(function(item) {}));
       downloads.download(
           {'url': SAFE_FAST_URL},
           function(id) {
             chrome.test.assertEq(getNextId(), id);
           });
     },
@@ skipping 133 matching lines @@
     },
     function cleanUp() {
       // cleanUp must come last. It clears out all in-progress downloads
       // so the browser can shutdown cleanly.
       for (var id = 0; id < nextId; ++id) {
         downloads.cancel(id, chrome.test.callbackPass(function() {}));
       }
     }
   ]);
 });