Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Unified Diff: views/controls/native_control_gtk.cc

Issue 8202026: views: Some more layer change, and add/update some tests for layers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/native_control_gtk.cc
diff --git a/views/controls/native_control_gtk.cc b/views/controls/native_control_gtk.cc
index 965d34738c194215329ca08a25fb57a8b23bc847..a798bc600ac78ac42d515591c9ca5ea6dd5d61cd 100644
--- a/views/controls/native_control_gtk.cc
+++ b/views/controls/native_control_gtk.cc
@@ -172,15 +172,7 @@ void NativeControlGtk::ViewHierarchyChanged(bool is_add, View* parent,
}
void NativeControlGtk::VisibilityChanged(View* starting_from, bool is_visible) {
- if (!is_visible) {
- if (native_view()) {
- // We destroy the child widget when we become invisible because of the
- // performance cost of maintaining widgets that aren't currently needed.
- Detach();
- // Make sure that Detach destroyed the widget.
- DCHECK(!native_view());
- }
- } else if (!native_view()) {
+ if (!native_view()) {
if (GetWidget())
CreateNativeControl();
} else {

Powered by Google App Engine
This is Rietveld 408576698