Issue 8202019: Properly support BGRA textures on desktop GL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8202019: Properly support BGRA textures on desktop GL (Closed)

Created:
9 years, 2 months ago by piman

Modified:
9 years, 2 months ago

Reviewers:
Ken Russell (switch to Gerrit), commit-bot: I haz the power

CC:
chromium-reviews, darin-cc_chromium.org, apatrick_chromium

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Properly support BGRA textures on desktop GL On GLES2, you must have internalFormat == format. That's what WebKit passes to WebGraphicsContext3DInProcessImpl. On Desktop GL, internalFormat must be one of RGBA* for BGRA textures. This patch does the proper translation. BUG=None TEST=WebKit compositor Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104674

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	webkit/gpu/webgraphicscontext3d_in_process_impl.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8202019/1

9 years, 2 months ago (2011-10-09 07:10:38 UTC) #3

Change committed as 104674

Expand Messages | Collapse Messages