Notify users about certain changes in installed extensions.

chrome/browser/extensions/extension_prefs_unittest.cc

Index: chrome/browser/extensions/extension_prefs_unittest.cc
diff --git a/chrome/browser/extensions/extension_prefs_unittest.cc b/chrome/browser/extensions/extension_prefs_unittest.cc
index d10e1839d6d7b87baac2655ef2f5e66a4c5cf35d..3e2c63dddb1af58884adbaf24ca1a908080463a2 100644
--- a/chrome/browser/extensions/extension_prefs_unittest.cc
+++ b/chrome/browser/extensions/extension_prefs_unittest.cc
@@ -443,6 +443,82 @@ class ExtensionPrefsBlacklist : public ExtensionPrefsTest {
 };
 TEST_F(ExtensionPrefsBlacklist, Blacklist) {}
 
+class ExtensionPrefsAcknowledgment : public ExtensionPrefsTest {
+ public:
+  virtual void Initialize() {
+    not_installed_id_ = "pghjnghklobnfoidcldiidjjjhkeeaoi";
+
+    // Install some extensions.
+    for (int i = 0; i < 5; i++) {
+      std::string name = "test" + base::IntToString(i);
+      extensions_.push_back(prefs_.AddExtension(name));
+    }
+    EXPECT_EQ(NULL, prefs()->GetInstalledExtensionInfo(not_installed_id_));
+
+    ExtensionList::const_iterator iter;
+    for (iter = extensions_.begin(); iter != extensions_.end(); ++iter) {
+      std::string id = (*iter)->id();
+      EXPECT_FALSE(prefs()->IsExternalExtensionAcknowledged(id));
+      EXPECT_FALSE(prefs()->IsBlacklistedExtensionAcknowledged(id));
+      EXPECT_FALSE(prefs()->IsOrphanedExtensionAcknowledged(id));
+      if (external_id_.empty()) {
+        external_id_ = id;
+        continue;
+      }
+      if (blacklisted_id_.empty()) {
+        blacklisted_id_ = id;
+        continue;
+      }
+      if (orphaned_id_.empty()) {
+        orphaned_id_ = id;
+        continue;
+      }
+    }
+    // For each type of acknowledgment, acknowledge one installed and one
+    // not-installed extension id.
+    prefs()->AcknowledgeExternalExtension(external_id_);
+    prefs()->AcknowledgeBlacklistedExtension(blacklisted_id_);
+    prefs()->AcknowledgeOrphanedExtension(orphaned_id_);
+    prefs()->AcknowledgeExternalExtension(not_installed_id_);
+    prefs()->AcknowledgeBlacklistedExtension(not_installed_id_);
+    prefs()->AcknowledgeOrphanedExtension(not_installed_id_);
+  }
+
+  virtual void Verify() {
+    ExtensionList::const_iterator iter;
+    for (iter = extensions_.begin(); iter != extensions_.end(); ++iter) {
+      std::string id = (*iter)->id();
+      if (id == external_id_) {
+        EXPECT_TRUE(prefs()->IsExternalExtensionAcknowledged(id));
+      } else {
+        EXPECT_FALSE(prefs()->IsExternalExtensionAcknowledged(id));
+      }
+      if (id == blacklisted_id_) {
+        EXPECT_TRUE(prefs()->IsBlacklistedExtensionAcknowledged(id));
+      } else {
+        EXPECT_FALSE(prefs()->IsBlacklistedExtensionAcknowledged(id));
+      }
+      if (id == orphaned_id_) {
+        EXPECT_TRUE(prefs()->IsOrphanedExtensionAcknowledged(id));
+      } else {
+        EXPECT_FALSE(prefs()->IsOrphanedExtensionAcknowledged(id));
+      }
+    }
+    EXPECT_TRUE(prefs()->IsExternalExtensionAcknowledged(not_installed_id_));
+    EXPECT_TRUE(prefs()->IsBlacklistedExtensionAcknowledged(not_installed_id_));
+    EXPECT_TRUE(prefs()->IsOrphanedExtensionAcknowledged(not_installed_id_));
+  }
+
+ private:
+  ExtensionList extensions_;
+
+  std::string not_installed_id_;
+  std::string external_id_;
+  std::string blacklisted_id_;
+  std::string orphaned_id_;
+};
+TEST_F(ExtensionPrefsAcknowledgment, Acknowledgment) {}

[asargent_no_longer_on_chrome, 2011/10/07 21:25:34]

Not necessary for this CL, but it would be nice to eventually see a test for
your "fuse" method behavior here. You could take advantage of the fact that
Verify gets called twice (you might need to add something to keep track of first
versus second call). Perhaps add TODO or something.

+
 // Tests force hiding browser actions.
 class ExtensionPrefsHidingBrowserActions : public ExtensionPrefsTest {
  public: