Notify users about certain changes in installed extensions.

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
+#include "base/callback.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/stl_util.h"
 #include "base/string16.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "base/version.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_plugin_service_filter.h"
 #include "chrome/browser/extensions/apps_promo.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_accessibility_api.h"
 #include "chrome/browser/extensions/extension_bookmarks_module.h"
 #include "chrome/browser/extensions/extension_browser_event_router.h"
 #include "chrome/browser/extensions/extension_cookies_api.h"
 #include "chrome/browser/extensions/extension_data_deleter.h"
 #include "chrome/browser/extensions/extension_downloads_api.h"
 #include "chrome/browser/extensions/extension_error_reporter.h"
+#include "chrome/browser/extensions/extension_global_error.h"
 #include "chrome/browser/extensions/extension_history_api.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_input_ime_api.h"
 #include "chrome/browser/extensions/extension_install_ui.h"
 #include "chrome/browser/extensions/extension_management_api.h"
 #include "chrome/browser/extensions/extension_preference_api.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extension_processes_api.h"
 #include "chrome/browser/extensions/extension_special_storage_policy.h"
 #include "chrome/browser/extensions/extension_sync_data.h"
 #include "chrome/browser/extensions/extension_updater.h"
 #include "chrome/browser/extensions/extension_web_ui.h"
 #include "chrome/browser/extensions/extension_webnavigation_api.h"
 #include "chrome/browser/extensions/external_extension_provider_impl.h"
 #include "chrome/browser/extensions/external_extension_provider_interface.h"
 #include "chrome/browser/extensions/pending_extension_manager.h"
 #include "chrome/browser/net/chrome_url_request_context.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search_engines/template_url_service.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/sync/api/sync_change.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/themes/theme_service_factory.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/global_error_service.h"
+#include "chrome/browser/ui/global_error_service_factory.h"
 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
 #include "chrome/browser/ui/webui/favicon_source.h"
 #include "chrome/browser/ui/webui/ntp/shown_sections_handler.h"
 #include "chrome/common/child_process_logging.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_error_utils.h"
@@ skipping 2060 matching lines @@
   }
 
   // Uninstall all the unclaimed extensions.
   scoped_ptr<ExtensionPrefs::ExtensionsInfo> extensions_info(
       extension_prefs_->GetInstalledExtensionsInfo());
   for (size_t i = 0; i < extensions_info->size(); ++i) {
     ExtensionInfo* info = extensions_info->at(i).get();
     if (Extension::IsExternalLocation(info->extension_location))
       CheckExternalUninstall(info->extension_id);
   }
+
+#if false
+  // TODO(miket): enable upon completion of feature.
+  IdentifyAlertableExtensions();

[asargent_no_longer_on_chrome, 2011/10/07 21:25:34]

Here's a thought for you to consider - I think it clearly makes sense to alert
relatively soon after startup for newly installed external extensions, because
it's soon after startup that we scan for and install them. But for blacklisted
and orphaned ones, we'll find out about that after one of the periodic update
checks run by the ExtensionUpdater. At least for blacklisted ones, we disable
the extension immediately, so it might be nice to show the alert about that
right at the time it happens, instead of the next time the user starts up the
browser (which for many people might be days/weeks after this). 

[miket_OOO, 2011/10/07 22:38:22]

Agreed. I have a bad bug that's related, as described in the CL description:
that we don't display the alert at all until the next new window. In conjunction
with resolving when to display the alert, I'll figure out when to generate the
alert events. But not for this CL.

+#endif
+}
+
+void ExtensionService::IdentifyAlertableExtensions() {
+  CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  // Build up the lists of extensions that require acknowledgment.
+  // If this is the first time, grandfather extensions that would have
+  // caused notification.
+  scoped_ptr<ExtensionGlobalError> global_error(
+      new ExtensionGlobalError(this));
+  bool needs_alert = false;
+  for (ExtensionList::const_iterator iter = extensions_.begin();
+       iter != extensions_.end(); ++iter) {
+    const Extension* e = *iter;
+    if (!IsExtensionEnabled(e->id())) {
+      continue;
+    }
+    if (Extension::IsExternalLocation(e->location())) {
+      if (!extension_prefs_->IsExternalExtensionAcknowledged(e->id())) {
+        global_error->AddExternalExtension(e->id());
+        needs_alert = true;
+      }
+    }
+    if (extension_prefs_->IsExtensionBlacklisted(e->id())) {
+      if (!extension_prefs_->IsBlacklistedExtensionAcknowledged(e->id())) {
+        global_error->AddBlacklistedExtension(e->id());
+        needs_alert = true;
+      }
+    }
+    if (extension_prefs_->IsExtensionOrphaned(e->id())) {
+      if (!extension_prefs_->IsOrphanedExtensionAcknowledged(e->id())) {
+        global_error->AddOrphanedExtension(e->id());
+        needs_alert = true;
+      }
+    }
+  }
+
+  if (needs_alert) {
+    if (extension_prefs_->IsNotificationSystemInitialized()) {
+      global_error->set_accept_callback(
+          base::Bind(&ExtensionService::HandleNotificationAlertAccept,
+                     base::Unretained(this)));
+      global_error->set_cancel_callback(
+          base::Bind(&ExtensionService::HandleNotificationAlertDetails,
+                     base::Unretained(this)));
+      GlobalErrorServiceFactory::GetForProfile(profile_)->AddGlobalError(
+          global_error.release());
+    } else {
+      // First run. Just acknowledge all the extensions, silently, by
+      // shortcutting the display of the UI and going straight to the
+      // callback for pressing the Accept button.
+      HandleNotificationAlertAccept(*global_error.get());
+    }
+  }
+}
+
+void ExtensionService::HandleNotificationAlertAccept(
+    const ExtensionGlobalError& global_error) {
+  const ExtensionIdSet *extension_ids =
+      global_error.get_external_extension_ids();
+  for (ExtensionIdSet::const_iterator iter = extension_ids->begin();
+       iter != extension_ids->end(); ++iter) {
+    extension_prefs_->AcknowledgeExternalExtension(*iter);
+  }
+  extension_ids = global_error.get_blacklisted_extension_ids();
+  for (ExtensionIdSet::const_iterator iter = extension_ids->begin();
+       iter != extension_ids->end(); ++iter) {
+    extension_prefs_->AcknowledgeBlacklistedExtension(*iter);
+  }
+  extension_ids = global_error.get_orphaned_extension_ids();
+  for (ExtensionIdSet::const_iterator iter = extension_ids->begin();
+       iter != extension_ids->end(); ++iter) {
+    extension_prefs_->AcknowledgeOrphanedExtension(*iter);
+  }
+}
+
+void ExtensionService::HandleNotificationAlertDetails(
+    const ExtensionGlobalError& global_error) {
+  Browser::OpenExtensionsWindow(profile_);
 }
 
 void ExtensionService::UnloadExtension(
     const std::string& extension_id,
     extension_misc::UnloadedExtensionReason reason) {
   // Make sure the extension gets deleted after we return from this function.
   scoped_refptr<const Extension> extension(
       GetExtensionByIdInternal(extension_id, true, true, false));
 
   // This method can be called via PostTask, so the extension may have been
@@ skipping 749 matching lines @@
 
 ExtensionService::NaClModuleInfoList::iterator
     ExtensionService::FindNaClModule(const GURL& url) {
   for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin();
        iter != nacl_module_list_.end(); ++iter) {
     if (iter->url == url)
       return iter;
   }
   return nacl_module_list_.end();
 }