Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/browser/printing/printing_message_filter.cc

Issue 8201027: Move margin processing code to the browser process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/printing_message_filter.cc
diff --git a/chrome/browser/printing/printing_message_filter.cc b/chrome/browser/printing/printing_message_filter.cc
index 98bcc6f344ea31f4bd9cc461f067684deb4f1605..5a3c3fd78798d9f82c3fbcff24d3618c0069d2a5 100644
--- a/chrome/browser/printing/printing_message_filter.cc
+++ b/chrome/browser/printing/printing_message_filter.cc
@@ -47,8 +47,8 @@ void RenderParamsFromPrintSettings(const printing::PrintSettings& settings,
params->printable_size.SetSize(
settings.page_setup_device_units().content_area().width(),
settings.page_setup_device_units().content_area().height());
- params->margin_top = settings.page_setup_device_units().content_area().x();
vandebo (ex-Chrome) 2011/10/08 01:27:24 This is a long outstanding bug, that apparently ha
- params->margin_left = settings.page_setup_device_units().content_area().y();
+ params->margin_top = settings.page_setup_device_units().content_area().y();
+ params->margin_left = settings.page_setup_device_units().content_area().x();
params->dpi = settings.dpi();
// Currently hardcoded at 1.25. See PrintSettings' constructor.
params->min_shrink = settings.min_shrink;
@@ -206,7 +206,7 @@ void PrintingMessageFilter::OnGetDefaultPrintSettings(IPC::Message* reply_msg) {
NULL,
0,
false,
- true,
+ printing::DEFAULT_MARGINS,
task);
}
@@ -257,7 +257,7 @@ void PrintingMessageFilter::OnScriptedPrint(
host_view,
params.expected_pages_count,
params.has_selection,
- params.use_overlays,
+ params.margin_type,
task);
}

Powered by Google App Engine
This is Rietveld 408576698