Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 8201012: Do not throw an exception if git cl rebase fails. (Closed)

Created:
9 years, 2 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Do not throw an exception if git cl rebase fails. Otherwise I get a stack trace and it's annoying as hell. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M git_cl.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years, 2 months ago (2011-10-07 19:07:55 UTC) #1
Dirk Pranke
lgtm. I'm kinda surprised we even have this command ...
9 years, 2 months ago (2011-10-07 20:46:09 UTC) #2
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8201012/1
9 years, 2 months ago (2011-10-10 19:49:25 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-10 19:55:29 UTC) #4
Change committed as 104770

Powered by Google App Engine
This is Rietveld 408576698