Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 8200017: [Multi Profile] Add "Delete this user" button for singleton profiles. (Closed)

Created:
9 years, 2 months ago by binji
Modified:
9 years, 2 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[Multi Profile] Add "Delete this user" button for singleton profiles. BUG=93835 TEST=Go to chrome://settings/personal, delete profiles until you have one. It should say "Delete this user...". If you have >1 profiles it should say "Delete...". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104902

Patch Set 1 #

Total comments: 2

Patch Set 2 : " #

Patch Set 3 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/personal_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/personal_options.js View 1 2 2 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
binji
9 years, 2 months ago (2011-10-07 22:34:49 UTC) #1
James Hawkins
http://codereview.chromium.org/8200017/diff/1/chrome/browser/resources/options/personal_options.js File chrome/browser/resources/options/personal_options.js (right): http://codereview.chromium.org/8200017/diff/1/chrome/browser/resources/options/personal_options.js#newcode63 chrome/browser/resources/options/personal_options.js:63: var hasOneProfile = profilesList.dataModel.length <= 1; What if the ...
9 years, 2 months ago (2011-10-08 18:17:39 UTC) #2
binji
http://codereview.chromium.org/8200017/diff/1/chrome/browser/resources/options/personal_options.js File chrome/browser/resources/options/personal_options.js (right): http://codereview.chromium.org/8200017/diff/1/chrome/browser/resources/options/personal_options.js#newcode63 chrome/browser/resources/options/personal_options.js:63: var hasOneProfile = profilesList.dataModel.length <= 1; On 2011/10/08 18:17:39, ...
9 years, 2 months ago (2011-10-10 17:23:03 UTC) #3
James Hawkins
lgtm
9 years, 2 months ago (2011-10-10 18:02:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/8200017/6001
9 years, 2 months ago (2011-10-11 02:12:38 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-10-11 15:41:17 UTC) #6
Change committed as 104902

Powered by Google App Engine
This is Rietveld 408576698