Issue 8200010: Sanity check the printable area returned by windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8200010: Sanity check the printable area returned by windows. (Closed)

Created:
9 years, 2 months ago by vandebo (ex-Chrome)

Modified:
9 years, 2 months ago

Reviewers:
Lei Zhang, commit-bot: I haz the power

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Sanity check the printable area returned by windows. BUG=96063 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104615

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -3 lines)			Patch
M	chrome/renderer/print_web_view_helper.cc	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	printing/page_setup.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	printing/print_settings_initializer_win.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

http://codereview.chromium.org/8200010/diff/1/chrome/renderer/print_web_view_helper.cc File chrome/renderer/print_web_view_helper.cc (right): http://codereview.chromium.org/8200010/diff/1/chrome/renderer/print_web_view_helper.cc#newcode988 chrome/renderer/print_web_view_helper.cc:988: CHECK(frame != NULL); I'm leaving this check in because ...

9 years, 2 months ago (2011-10-07 19:50:00 UTC) #1

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/8200010/1

9 years, 2 months ago (2011-10-07 22:18:35 UTC) #3

Change committed as 104615

Expand Messages | Collapse Messages