Allow controlling the Instant field trial through a command line flag.

Allow controlling the Instant field trial through a command line flag.

This also allows us to disable the field trial for all tests, without
hacking around the kInstantEnabledOnce preference.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104794

[sreeram, 2011-10-08 04:15:06]

Please review.

[sreeram, 2011-10-09 00:33:07]

Does anyone know how I can test the change to the pyauto tests? I.e., how do I
run the pyauto tests on say, the mac? The instructions at
http://www.chromium.org/developers/testing/pyauto don't work for me (the tests
hang, with or without my change). The try bots don't seem to run the tests
either.

[Nirnimesh, 2011-10-09 19:59:20]

On 2011/10/09 00:33:07, sreeram wrote:
> Does anyone know how I can test the change to the pyauto tests? I.e., how do I
> run the pyauto tests on say, the mac? The instructions at
> http://www.chromium.org/developers/testing/pyauto don't work for me (the tests
> hang, with or without my change).

Where does it hang? Does it not load the browser?

> The try bots don't seem to run the tests
> either.

FAQ #5 says "Use -t pyauto_functional_tests argument to your try job"

[sreeram, 2011-10-09 22:52:43]

On Sun, Oct 9, 2011 at 12:59,  <nirnimesh@chromium.org> wrote:
> On 2011/10/09 00:33:07, sreeram wrote:
>>
>> Does anyone know how I can test the change to the pyauto tests? I.e., how
>> do I
>> run the pyauto tests on say, the mac? The instructions at
>> http://www.chromium.org/developers/testing/pyauto don't work for me (the
>> tests
>> hang, with or without my change).
>
> Where does it hang? Does it not load the browser?

Ah, it turns out it's because Instant was recently restricted to do
only URLs (http://crrev.com/104553). The test needs to be updated to
deal with that (it hangs because it currently tries to preview a URL,
not a search, and the preview never appears). Bug filed:
http://crbug.com/99638

>> The try bots don't seem to run the tests
>> either.
>
> FAQ #5 says "Use -t pyauto_functional_tests argument to your try job"
>
>
>
> http://codereview.chromium.org/8198027/
>

[sky, 2011-10-10 15:23:01]

LGTM

[sreeram, 2011-10-10 18:19:57]

On 2011/10/10 15:23:01, sky wrote:
> LGTM

Thanks.

@phajdan.jr, @nirnimesh: Pawel/Nirnimesh, any coments? Or, shall I go ahead and
commit this?

[Nirnimesh, 2011-10-10 18:27:20]

LGTM. I've disabled instant pyauto tests for the time. They need to be updated
with the new expecatations.

[Paweł Hajdan Jr., 2011-10-10 19:45:14]

LGTM, thanks

[commit-bot: I haz the power, 2011-10-10 19:46:49]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/sreeram@chromium.org/8198027/1

[commit-bot: I haz the power, 2011-10-10 21:55:33]

Change committed as 104794