Issue 8198017: Allow FlushSyncs to short circuit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8198017: Allow FlushSyncs to short circuit (Closed)

Created:
9 years, 2 months ago by jbauman

Modified:
9 years, 1 month ago

Reviewers:
commit-bot: I haz the power, apatrick_chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Allow FlushSyncs to short circuit All messages on a channel are now executed in order, so Flushs have to wait for all previous AsyncFlushs to finish. This is generally unnecessary, so we replace Flush with a GetStateFast message. All commands are queued up when they enter the gpu process, and GetStateFast commands are moved to the head of the line. BUG= TEST=trybots, webgl conformance tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104786

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -110 lines)			Patch
M	content/common/gpu/gpu_channel.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	content/common/gpu/gpu_channel.cc	View	5 chunks	+47 lines, -45 lines	0 comments	Download
M	content/common/gpu/gpu_command_buffer_stub.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	content/common/gpu/gpu_command_buffer_stub.cc	View	2 chunks	+13 lines, -45 lines	0 comments	Download
M	content/common/gpu/gpu_messages.h	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	content/renderer/gpu/command_buffer_proxy.cc	View	2 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/8198017/1

9 years, 2 months ago (2011-10-10 19:54:03 UTC) #3

piman

9 years, 1 month ago (2011-10-31 22:59:12 UTC) #5

On 2011/10/10 21:14:35, I haz the power (commit-bot) wrote:
> Change committed as 104786

I think this is causing
http://code.google.com/p/chromium-os/issues/detail?id=21566
When the renderer is doing a FlushSync, it can starve the gpu process by sending
GpuCommandBufferMsg_GetStateFast messages in a loop without giving a chance to
the GPU process to make progress

Expand Messages | Collapse Messages