Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: chrome/common/json_pref_store.cc

Issue 8198007: Remove PrefService::ScheduleSavePersistentPrefs and SavePersistentPrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/json_pref_store.h ('k') | chrome/common/json_pref_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/json_pref_store.cc
diff --git a/chrome/common/json_pref_store.cc b/chrome/common/json_pref_store.cc
index 4fe393aa3d8fe64692de8a25c6085bd72274a7cc..ccb639871a6ef282115d3c54f4fdb2aca20a06d7 100644
--- a/chrome/common/json_pref_store.cc
+++ b/chrome/common/json_pref_store.cc
@@ -282,26 +282,6 @@ PersistentPrefStore::PrefReadError JsonPrefStore::ReadPrefs() {
return error;
}
-bool JsonPrefStore::WritePrefs() {
- std::string data;
- if (!SerializeData(&data))
- return false;
-
- // Don't actually write prefs if we're read-only or don't have any pending
- // writes.
- // TODO(bauerb): Make callers of this method call CommitPendingWrite directly.
- if (writer_.HasPendingWrite() && !read_only_)
- writer_.WriteNow(data);
-
- return true;
-}
-
-void JsonPrefStore::ScheduleWritePrefs() {
- // Writing prefs should be scheduled automatically, so this is a no-op
- // for now.
- // TODO(bauerb): Remove calls to this method.
-}
-
void JsonPrefStore::CommitPendingWrite() {
if (writer_.HasPendingWrite() && !read_only_)
writer_.DoScheduledWrite();
« no previous file with comments | « chrome/common/json_pref_store.h ('k') | chrome/common/json_pref_store_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698