Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Side by Side Diff: chrome/common/json_pref_store.h

Issue 8198007: Remove PrefService::ScheduleSavePersistentPrefs and SavePersistentPrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix chromeos Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_JSON_PREF_STORE_H_ 5 #ifndef CHROME_COMMON_JSON_PREF_STORE_H_
6 #define CHROME_COMMON_JSON_PREF_STORE_H_ 6 #define CHROME_COMMON_JSON_PREF_STORE_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 17 matching lines...) Expand all
28 public ImportantFileWriter::DataSerializer { 28 public ImportantFileWriter::DataSerializer {
29 public: 29 public:
30 // |file_message_loop_proxy| is the MessageLoopProxy for a thread on which 30 // |file_message_loop_proxy| is the MessageLoopProxy for a thread on which
31 // file I/O can be done. 31 // file I/O can be done.
32 JsonPrefStore(const FilePath& pref_filename, 32 JsonPrefStore(const FilePath& pref_filename,
33 base::MessageLoopProxy* file_message_loop_proxy); 33 base::MessageLoopProxy* file_message_loop_proxy);
34 virtual ~JsonPrefStore(); 34 virtual ~JsonPrefStore();
35 35
36 // PrefStore overrides: 36 // PrefStore overrides:
37 virtual ReadResult GetValue(const std::string& key, 37 virtual ReadResult GetValue(const std::string& key,
38 const base::Value** result) const; 38 const base::Value** result) const OVERRIDE;
Mattias Nissler (ping if slow) 2011/10/12 09:23:39 #include "base/compiler_specific.h"
Bernhard Bauer 2011/10/12 11:00:11 Done.
39 virtual void AddObserver(PrefStore::Observer* observer); 39 virtual void AddObserver(PrefStore::Observer* observer) OVERRIDE;
40 virtual void RemoveObserver(PrefStore::Observer* observer); 40 virtual void RemoveObserver(PrefStore::Observer* observer) OVERRIDE;
41 virtual bool IsInitializationComplete() const; 41 virtual bool IsInitializationComplete() const OVERRIDE;
42 42
43 // PersistentPrefStore overrides: 43 // PersistentPrefStore overrides:
44 virtual ReadResult GetMutableValue(const std::string& key, 44 virtual ReadResult GetMutableValue(const std::string& key,
45 base::Value** result); 45 base::Value** result) OVERRIDE;
46 virtual void SetValue(const std::string& key, base::Value* value); 46 virtual void SetValue(const std::string& key, base::Value* value) OVERRIDE;
47 virtual void SetValueSilently(const std::string& key, base::Value* value); 47 virtual void SetValueSilently(const std::string& key,
48 virtual void RemoveValue(const std::string& key); 48 base::Value* value) OVERRIDE;
49 virtual bool ReadOnly() const; 49 virtual void RemoveValue(const std::string& key) OVERRIDE;
50 virtual PrefReadError ReadPrefs(); 50 virtual bool ReadOnly() const OVERRIDE;
51 virtual void ReadPrefsAsync(ReadErrorDelegate* error_delegate); 51 virtual PrefReadError ReadPrefs() OVERRIDE;
52 virtual bool WritePrefs(); 52 virtual void ReadPrefsAsync(ReadErrorDelegate* error_delegate) OVERRIDE;
53 virtual void ScheduleWritePrefs(); 53 virtual void CommitPendingWrite() OVERRIDE;
54 virtual void CommitPendingWrite(); 54 virtual void ReportValueChanged(const std::string& key) OVERRIDE;
55 virtual void ReportValueChanged(const std::string& key);
56 55
57 // This method is called after JSON file has been read. Method takes 56 // This method is called after JSON file has been read. Method takes
58 // ownership of the |value| pointer. Note, this method is used with 57 // ownership of the |value| pointer. Note, this method is used with
59 // asynchronous file reading, so class exposes it only for the internal needs. 58 // asynchronous file reading, so class exposes it only for the internal needs.
60 // (read: do not call it manually). 59 // (read: do not call it manually).
61 void OnFileRead(base::Value* value_owned, PrefReadError error, bool no_dir); 60 void OnFileRead(base::Value* value_owned, PrefReadError error, bool no_dir);
62 61
63 private: 62 private:
64 // ImportantFileWriter::DataSerializer overrides: 63 // ImportantFileWriter::DataSerializer overrides:
65 virtual bool SerializeData(std::string* output); 64 virtual bool SerializeData(std::string* output);
(...skipping 11 matching lines...) Expand all
77 ObserverList<PrefStore::Observer, true> observers_; 76 ObserverList<PrefStore::Observer, true> observers_;
78 77
79 scoped_ptr<ReadErrorDelegate> error_delegate_; 78 scoped_ptr<ReadErrorDelegate> error_delegate_;
80 79
81 bool initialized_; 80 bool initialized_;
82 81
83 DISALLOW_COPY_AND_ASSIGN(JsonPrefStore); 82 DISALLOW_COPY_AND_ASSIGN(JsonPrefStore);
84 }; 83 };
85 84
86 #endif // CHROME_COMMON_JSON_PREF_STORE_H_ 85 #endif // CHROME_COMMON_JSON_PREF_STORE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698