Remove PrefService::ScheduleSavePersistentPrefs and SavePersistentPrefs.

chrome/browser/translate/translate_prefs.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/translate/translate_prefs.h"
 
 #include "base/string_util.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/prefs/scoped_user_pref_update.h"
 
@@ skipping 56 matching lines @@
 void TranslatePrefs::WhitelistLanguagePair(
     const std::string& original_language,
     const std::string& target_language) {
   DictionaryPrefUpdate update(prefs_, kPrefTranslateWhitelists);
   DictionaryValue* dict = update.Get();
   if (!dict) {
     NOTREACHED() << "Unregistered translate whitelist pref";
     return;
   }
   dict->SetString(original_language, target_language);
-  prefs_->ScheduleSavePersistentPrefs();
 }
 
 void TranslatePrefs::RemoveLanguagePairFromWhitelist(
     const std::string& original_language,
     const std::string& target_language) {
   DictionaryPrefUpdate update(prefs_, kPrefTranslateWhitelists);
   DictionaryValue* dict = update.Get();
   if (!dict) {
     NOTREACHED() << "Unregistered translate whitelist pref";
     return;
   }
-  if (dict->Remove(original_language, NULL))
-    prefs_->ScheduleSavePersistentPrefs();
+  dict->Remove(original_language, NULL);
 }
 
 int TranslatePrefs::GetTranslationDeniedCount(const std::string& language) {
   const DictionaryValue* dict =
       prefs_->GetDictionary(kPrefTranslateDeniedCount);
   int count = 0;
   return dict->GetInteger(language, &count) ? count : 0;
 }
 
 void TranslatePrefs::IncrementTranslationDeniedCount(
@@ skipping 85 matching lines @@
   //   target lang overwrites the previous one.
   // - this results in a one-to-one relationship between source lang and target
   //   lang
   // - we replace old list of target langs with the last target lang in list,
   //   assuming the last (i.e. most recent) target lang is what user wants to
   //   keep auto-translated.
   DictionaryPrefUpdate update(user_prefs, kPrefTranslateWhitelists);
   DictionaryValue* dict = update.Get();
   if (!dict || dict->empty())
     return;
-  bool save_prefs = false;
   for (DictionaryValue::key_iterator iter(dict->begin_keys());
        iter != dict->end_keys(); ++iter) {
     ListValue* list = NULL;
     if (!dict->GetList(*iter, &list) || !list)
       break;  // Dictionary has either been migrated or new format.
-    save_prefs = true;
     std::string target_lang;
     if (list->empty() || !list->GetString(list->GetSize() - 1, &target_lang) ||
         target_lang.empty())
       dict->Remove(*iter, NULL);
      else
       dict->SetString(*iter, target_lang);
   }
-  if (!save_prefs)
-    return;
-  user_prefs->ScheduleSavePersistentPrefs();
 }
 
 // TranslatePrefs: private: ----------------------------------------------------
 
 bool TranslatePrefs::IsValueInList(const ListValue* list,
     const std::string& in_value) {
   for (size_t i = 0; i < list->GetSize(); ++i) {
     std::string value;
     if (list->GetString(i, &value) && value == in_value)
       return true;
@@ skipping 11 matching lines @@
     const std::string& value) {
   {
     ListPrefUpdate update(prefs_, pref_id);
     ListValue* blacklist = update.Get();
     if (!blacklist) {
       NOTREACHED() << "Unregistered translate blacklist pref";
       return;
     }
     blacklist->Append(new StringValue(value));
   }
-  prefs_->ScheduleSavePersistentPrefs();
 }
 
 void TranslatePrefs::RemoveValueFromBlacklist(const char* pref_id,
     const std::string& value) {
-  bool schedule_save = false;
-  {
-    ListPrefUpdate update(prefs_, pref_id);
-    ListValue* blacklist = update.Get();
-    if (!blacklist) {
-      NOTREACHED() << "Unregistered translate blacklist pref";
-      return;
-    }
-    StringValue string_value(value);
-    schedule_save = blacklist->Remove(string_value, NULL);
+  ListPrefUpdate update(prefs_, pref_id);
+  ListValue* blacklist = update.Get();
+  if (!blacklist) {
+    NOTREACHED() << "Unregistered translate blacklist pref";
+    return;
   }
-  if (schedule_save)
-    prefs_->ScheduleSavePersistentPrefs();
+  StringValue string_value(value);
+  blacklist->Remove(string_value, NULL);
 }
 
 bool TranslatePrefs::IsLanguageWhitelisted(
     const std::string& original_language, std::string* target_language) {
   const DictionaryValue* dict = prefs_->GetDictionary(kPrefTranslateWhitelists);
   if (dict && dict->GetString(original_language, target_language)) {
     DCHECK(!target_language->empty());
     return !target_language->empty();
   }
   return false;
 }