Remove PrefService::ScheduleSavePersistentPrefs and SavePersistentPrefs.

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/environment.h"
 #include "base/file_path.h"
@@ skipping 906 matching lines @@
     browser::MigrateBrowserPrefs(prefs_.get(),
                                  g_browser_process->local_state());
   }
 
   // The last session exited cleanly if there is no pref for
   // kSessionExitedCleanly or the value for kSessionExitedCleanly is true.
   last_session_exited_cleanly_ =
       prefs_->GetBoolean(prefs::kSessionExitedCleanly);
   // Mark the session as open.
   prefs_->SetBoolean(prefs::kSessionExitedCleanly, false);
-  // Make sure we save to disk that the session has opened.
-  prefs_->ScheduleSavePersistentPrefs();

[Mattias Nissler (ping if slow), 2011/10/12 09:23:39]

At this point I think we actually want a CommitPendingWrite() in order to make
sure that crashes happening immediately after are detected as unclean exit.

[Bernhard Bauer, 2011/10/12 11:00:11]

Hm, could this adversely affect startup performance, or am I being overly
paranoid here?

[Mattias Nissler (ping if slow), 2011/10/12 11:02:27]

Ah, the old fast vs. correct tradeoff :) I'm OK either way.

 
   bool extensions_disabled =
       prefs_->GetBoolean(prefs::kDisableExtensions) ||
       CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableExtensions);
 
   // Ensure that preferences set by extensions are restored in the profile
   // as early as possible. The constructor takes care of that.
   extension_prefs_.reset(new ExtensionPrefs(
       prefs_.get(),
       GetPath().AppendASCII(ExtensionService::kInstallDirectoryName),
@@ skipping 522 matching lines @@
   return webkit_context_.get();
 }
 
 void ProfileImpl::MarkAsCleanShutdown() {
   if (prefs_.get()) {
     // The session cleanly exited, set kSessionExitedCleanly appropriately.
     prefs_->SetBoolean(prefs::kSessionExitedCleanly, true);
 
     // NOTE: If you change what thread this writes on, be sure and update
     // ChromeFrame::EndSession().
-    prefs_->SavePersistentPrefs();
+    prefs_->CommitPendingWrite();
   }
 }
 
 void ProfileImpl::Observe(int type,
                           const NotificationSource& source,
                           const NotificationDetails& details) {
   switch (type) {
     case chrome::NOTIFICATION_PREF_INITIALIZATION_COMPLETED: {
       bool* succeeded = Details<bool>(details).ptr();
       PrefService *prefs = Source<PrefService>(source).ptr();
@@ skipping 230 matching lines @@
       NOTREACHED();
       break;
     }
   }
   if (do_update_pref)
     GetPrefs()->SetString(prefs::kApplicationLocale, new_locale);
   local_state->SetString(prefs::kApplicationLocale, new_locale);
 
   if (chromeos::UserManager::Get()->current_user_is_owner())
     local_state->SetString(prefs::kOwnerLocale, new_locale);
-
-  GetPrefs()->ScheduleSavePersistentPrefs();
-  local_state->ScheduleSavePersistentPrefs();
 }
 
 void ProfileImpl::OnLogin() {
   if (locale_change_guard_ == NULL)
     locale_change_guard_.reset(new chromeos::LocaleChangeGuard(this));
   locale_change_guard_->OnLogin();
 }
 
 void ProfileImpl::SetupChromeOSEnterpriseExtensionObserver() {
   DCHECK(!chromeos_enterprise_extension_observer_.get());
@@ skipping 25 matching lines @@
 SpellCheckProfile* ProfileImpl::GetSpellCheckProfile() {
   if (!spellcheck_profile_.get())
     spellcheck_profile_.reset(new SpellCheckProfile());
   return spellcheck_profile_.get();
 }
 
 void ProfileImpl::SetDownloadManagerDelegate(
     ChromeDownloadManagerDelegate* delegate) {
   download_manager_delegate_ = delegate;
 }