chrome/browser/extensions/unpacked_installer.cc - Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/unpacked_installer.cc

Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Correct inlining Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_prefs.cc ('K') | « chrome/browser/extensions/test_extension_prefs.cc ('k') | chrome/browser/resources/ntp4/page_list_view.js » ('j') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/unpacked_installer.cc

diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc

index eccf2751cef585ccfc9863c51977bc1a16f61448..139b48c030945422633fa299764d153d6596c8f0 100644

--- a/chrome/browser/extensions/unpacked_installer.cc

+++ b/chrome/browser/extensions/unpacked_installer.cc

@@ -12,6 +12,7 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_file_util.h"

+#include "chrome/common/string_ordinal.h"

using content::BrowserThread;

@@ -56,7 +57,7 @@ void SimpleExtensionLoadPrompt::ShowPrompt() {

void SimpleExtensionLoadPrompt::InstallUIProceed() {

if (service_weak_.get())

service_weak_->OnExtensionInstalled(

- extension_, false, -1); // Not from web store.

+ extension_, false, StringOrdinal()); // Not from web store.

delete this;

}

@@ -212,7 +213,7 @@ void UnpackedInstaller::OnLoaded(

}

service_weak_->OnExtensionInstalled(extension,

false, // Not from web store.

- -1);

+ StringOrdinal());

}

} // namespace extensions