Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fixing problem with setting app page names Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 009dedbc23a8adc337eebb8e7c908e2f6c60a669..4a8adbae57ae4de1bf9b5b5fb41441d795008fb3 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -2024,7 +2024,9 @@ void ExtensionService::UpdateActiveExtensionsInCrashReporter() {
}
void ExtensionService::OnExtensionInstalled(
- const Extension* extension, bool from_webstore, int page_index) {
+ const Extension* extension,
+ bool from_webstore,
+ const StringOrdinal& page_ordinal) {
CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
// Ensure extension is deleted unless we transfer ownership.
@@ -2081,7 +2083,7 @@ void ExtensionService::OnExtensionInstalled(
extension,
initial_enable ? Extension::ENABLED : Extension::DISABLED,
from_webstore,
- page_index);
+ page_ordinal);
// Unpacked extensions default to allowing file access, but if that has been
// overridden, don't reset the value.

Powered by Google App Engine
This is Rietveld 408576698