chrome/browser/extensions/extension_browsertest.cc - Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fixing problem with setting app page names Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_prefs.h » ('j') | chrome/browser/extensions/extension_prefs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_browsertest.cc

diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc

index 24843017f1c9f84eb27b7082a9ba8252399284b2..87bed1536c6016c1c1f4bebae86cf0f0c8dede88 100644

--- a/chrome/browser/extensions/extension_browsertest.cc

+++ b/chrome/browser/extensions/extension_browsertest.cc

@@ -92,7 +92,8 @@ const Extension* ExtensionBrowserTest::LoadExtensionWithOptions(

// The call to OnExtensionInstalled ensures the other extension prefs

// are set up with the defaults.

service->extension_prefs()->OnExtensionInstalled(

- extension, Extension::ENABLED, false, 0);

+ extension, Extension::ENABLED, false,

+ StringOrdinal::CreateInitialOrdinal());

// Toggling incognito or file access will reload the extension, so wait for

// the reload and grab the new extension instance. The default state is

« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_prefs.h » ('j') | chrome/browser/extensions/extension_prefs.h » ('J')