chrome/browser/sync/test/integration/sync_extension_helper.cc - Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/sync_extension_helper.cc

Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Adding review comments Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/ntp4/page_list_view.js ('k') | chrome/browser/ui/panels/base_panel_browser_test.cc » ('j') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/sync_extension_helper.cc

diff --git a/chrome/browser/sync/test/integration/sync_extension_helper.cc b/chrome/browser/sync/test/integration/sync_extension_helper.cc

index a738ad9fae5b1cf63fad8523008c0afac3470977..cdab7fdec2374cdd4d3e64876c637398a78bdece 100644

--- a/chrome/browser/sync/test/integration/sync_extension_helper.cc

+++ b/chrome/browser/sync/test/integration/sync_extension_helper.cc

@@ -13,6 +13,7 @@

#include "chrome/browser/extensions/pending_extension_manager.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/common/extensions/extension_constants.h"

+#include "chrome/common/string_ordinal.h"

#include "chrome/browser/sync/test/integration/sync_test.h"

#include "chrome/browser/sync/test/integration/sync_datatype_helper.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -64,7 +65,7 @@ void SyncExtensionHelper::InstallExtension(

ASSERT_TRUE(extension.get()) << "Could not get extension " << name

<< " (profile = " << profile << ")";

profile->GetExtensionService()->OnExtensionInstalled(

- extension, extension->UpdatesFromGallery(), 0);

+ extension, extension->UpdatesFromGallery(), StringOrdinal());

}

void SyncExtensionHelper::UninstallExtension(