chrome/browser/resources/ntp4/page_list_view.js - Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp4/page_list_view.js

Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fixing compile error in integration test Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.h ('K') | « chrome/browser/extensions/unpacked_installer.cc ('k') | chrome/browser/sync/test/integration/sync_extension_helper.cc » ('j') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/ntp4/page_list_view.js

diff --git a/chrome/browser/resources/ntp4/page_list_view.js b/chrome/browser/resources/ntp4/page_list_view.js

index 7db35c0ba4dfa096f5d0e4480b76a0c36247543d..72579ddfc2c27105273687714c1fcb27910ec7ed 100644

--- a/chrome/browser/resources/ntp4/page_list_view.js

+++ b/chrome/browser/resources/ntp4/page_list_view.js

@@ -293,9 +293,9 @@ cr.define('ntp4', function() {

return true;

}

- // Sort by launch index

+ // Sort by launch ordinal

apps.sort(function(a, b) {

- return a.app_launch_index - b.app_launch_index;

+ return a.app_launch_ordinal > b.app_launch_ordinal;

});

// An app to animate (in case it was just installed).