chrome/browser/ui/webui/ntp/app_launcher_handler.h - Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/app_launcher_handler.h

Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Addressing review comments Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/panels/base_panel_browser_test.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/app_launcher_handler.h

diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.h b/chrome/browser/ui/webui/ntp/app_launcher_handler.h

index 82b55fb1d71fcb3f17de08cfb446e2ac4050acf7..7aa7692be815abf9370b1f9f61a4bdac40acddd4 100644

--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.h

+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.h

@@ -15,6 +15,7 @@

#include "chrome/browser/prefs/pref_change_registrar.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_constants.h"

+#include "chrome/common/string_ordinal.h"

#include "content/browser/cancelable_request.h"

#include "content/browser/webui/web_ui.h"

#include "content/public/browser/notification_observer.h"

@@ -114,7 +115,7 @@ class AppLauncherHandler : public WebUIMessageHandler,

bool is_bookmark_app;

string16 title;

GURL app_url;

- int page_index;

+ StringOrdinal page_index;

};

// Records a web store launch in the appropriate histograms. |promo_active|