chrome/browser/ui/panels/base_panel_browser_test.cc - Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/base_panel_browser_test.cc

Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Adding constness and comments Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_prefs.cc ('K') | « chrome/browser/resources/ntp4/page_list_view.js ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.h » ('j') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/base_panel_browser_test.cc

diff --git a/chrome/browser/ui/panels/base_panel_browser_test.cc b/chrome/browser/ui/panels/base_panel_browser_test.cc

index 992557bd1f9211e7ebcc3d240ab10b9032428804..93d2cd5dd7ed400f6894d41375d9765fb2d598e7 100644

--- a/chrome/browser/ui/panels/base_panel_browser_test.cc

+++ b/chrome/browser/ui/panels/base_panel_browser_test.cc

@@ -17,6 +17,7 @@

#include "chrome/browser/ui/panels/panel_manager.h"

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

#include "chrome/common/chrome_switches.h"

+#include "chrome/common/string_ordinal.h"

#include "chrome/test/base/ui_test_utils.h"

#include "content/browser/tab_contents/test_tab_contents.h"

#include "content/public/browser/notification_service.h"

@@ -355,6 +356,6 @@ scoped_refptr<Extension> BasePanelBrowserTest::CreateExtension(

EXPECT_TRUE(extension.get());

EXPECT_STREQ("", error.c_str());

browser()->GetProfile()->GetExtensionService()->

- OnExtensionInstalled(extension.get(), false, -1);

+ OnExtensionInstalled(extension.get(), false, StringOrdinal());

return extension;

}