Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: chrome/browser/extensions/crx_installer.cc

Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Adding constness and comments Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/crx_installer.h" 5 #include "chrome/browser/extensions/crx_installer.h"
6 6
7 #include <map> 7 #include <map>
8 #include <set> 8 #include <set>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 return false; 125 return false;
126 } 126 }
127 127
128 CrxInstaller::CrxInstaller(base::WeakPtr<ExtensionService> frontend_weak, 128 CrxInstaller::CrxInstaller(base::WeakPtr<ExtensionService> frontend_weak,
129 ExtensionInstallUI* client) 129 ExtensionInstallUI* client)
130 : install_directory_(frontend_weak->install_directory()), 130 : install_directory_(frontend_weak->install_directory()),
131 install_source_(Extension::INTERNAL), 131 install_source_(Extension::INTERNAL),
132 extensions_enabled_(frontend_weak->extensions_enabled()), 132 extensions_enabled_(frontend_weak->extensions_enabled()),
133 delete_source_(false), 133 delete_source_(false),
134 create_app_shortcut_(false), 134 create_app_shortcut_(false),
135 page_index_(-1),
136 frontend_weak_(frontend_weak), 135 frontend_weak_(frontend_weak),
137 profile_(frontend_weak->profile()), 136 profile_(frontend_weak->profile()),
138 client_(client), 137 client_(client),
139 apps_require_extension_mime_type_(false), 138 apps_require_extension_mime_type_(false),
140 allow_silent_install_(false), 139 allow_silent_install_(false),
141 install_cause_(extension_misc::INSTALL_CAUSE_UNSET), 140 install_cause_(extension_misc::INSTALL_CAUSE_UNSET),
142 creation_flags_(Extension::NO_FLAGS) { 141 creation_flags_(Extension::NO_FLAGS) {
143 } 142 }
144 143
145 CrxInstaller::~CrxInstaller() { 144 CrxInstaller::~CrxInstaller() {
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
599 // Some users (such as the download shelf) need to know when a 598 // Some users (such as the download shelf) need to know when a
600 // CRXInstaller is done. Listening for the EXTENSION_* events 599 // CRXInstaller is done. Listening for the EXTENSION_* events
601 // is problematic because they don't know anything about the 600 // is problematic because they don't know anything about the
602 // extension before it is unpacked, so they can not filter based 601 // extension before it is unpacked, so they can not filter based
603 // on the extension. 602 // on the extension.
604 content::NotificationService::current()->Notify( 603 content::NotificationService::current()->Notify(
605 chrome::NOTIFICATION_CRX_INSTALLER_DONE, 604 chrome::NOTIFICATION_CRX_INSTALLER_DONE,
606 content::Source<CrxInstaller>(this), 605 content::Source<CrxInstaller>(this),
607 content::NotificationService::NoDetails()); 606 content::NotificationService::NoDetails());
608 } 607 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698