Convert app_launch_index and page_index from int to StringOrdinal.

chrome/browser/resources/ntp4/new_tab.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview New tab page
  * This is the main code for the new tab page used by touch-enabled Chrome
  * browsers.  For now this is still a prototype.
  */
 
@@ skipping 336 matching lines @@
     function stringListIsEmpty(list) {
       for (var i = 0; i < list.length; i++) {
         if (list[i])
           return false;
       }
       return true;
     }
 
     // Sort by launch index
     apps.sort(function(a, b) {
-      return a.app_launch_index - b.app_launch_index;
+      return a.app_launch_index > b.app_launch_index;

[Dan Beam, 2011/11/12 02:28:30]

Hmmm, would it be better to

  return +a.app_launch_index - +b.app_launch_index;

to cast to decimal number or

  return window.parseInt(a.app_launch_index, 10) -
window.parseInt(b.app_launch_index);

possibly?

I guess this is OK as long as we never encounter something like

  "02" < "1" // true

I'm just trying to think of if this would ever result in strange bugs...

[csharp, 2011/11/14 16:22:28]

We don't want to do this because the app_launch_index values no longer have
integer values, they are represented as [a..z]*. Look at
chrome/common/string_ordinal.h for more information on exactly how they work.
Basically we've replaced the integers with StringOrdinals (which are
[b-z][a-z]*). They have the advantage that if we move an icon, we only need to
change the index of that icon to represent the new order, all the other values
can stay the same.

     });
 
     // An app to animate (in case it was just installed).
     var highlightApp;
 
     // Add the apps, creating pages as necessary
     for (var i = 0; i < apps.length; i++) {
       var app = apps[i];
       var pageIndex = (app.page_index || 0);
       while (pageIndex >= appsPages.length) {
@@ skipping 649 matching lines @@
 var getAppsCallback = ntp4.getAppsCallback;
 var appsPrefChangeCallback = ntp4.appsPrefChangeCallback;
 var themeChanged = ntp4.themeChanged;
 var recentlyClosedTabs = ntp4.setRecentlyClosedTabs;
 var setMostVisitedPages = ntp4.setMostVisitedPages;
 var updateLogin = ntp4.updateLogin;
 
 document.addEventListener('DOMContentLoaded', ntp4.initialize);
 window.addEventListener('online', ntp4.updateOfflineEnabledApps);
 window.addEventListener('offline', ntp4.updateOfflineEnabledApps);